Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 27, 2023

This is the successor to #3460, the plan is to add proper support for these types of tests and have both types in the codebase simultaneously. Instead of trying to migrate all unit tests at once, we can do it parts at a time and any new tests can be added using the new method.

This is a WIP and will only get merged when the integration feels solid.

Part of #3446
Part of #3326

@Tyriar Tyriar self-assigned this Aug 27, 2023
@Tyriar Tyriar added this to the 5.3.0 milestone Sep 1, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Sep 2, 2023

Up to 50% savings from the new integration test jobs 🎉

image

@Tyriar
Copy link
Member Author

Tyriar commented Sep 2, 2023

Actually the gain is a little nuanced as the addon tests are only done in the old tests now.

Here's an example of without the PR:

image

@Tyriar
Copy link
Member Author

Tyriar commented Sep 2, 2023

I didn't migrate all the tests to use the proxy as it doesn't need to happen to make the change. The addon tests also have not been brought over yet.

@Tyriar Tyriar marked this pull request as ready for review September 2, 2023 16:25
@Tyriar Tyriar merged commit 29dd30a into xtermjs:master Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant