Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 27, 2023

This helps us from making mistakes by registering the clearing of an optional disposable when it's created, instead of having to create and dispose in two separate spots.

This also fixes the following issues:

  • Texture atlases were getting disposed when canvas and webgl renderers were being disposed which could cause issues when they're shared. The disposal of the texture atlas is the duty of CharAtlasCache.removeTerminalFromCache
  • The following weren't being disposed of correctly before:
    • Terminal._accessibilityManager
    • WebglRenderer._rectangleRenderer
    • WebglRenderer._glyphRenderer

@Tyriar Tyriar added this to the 5.3.0 milestone Aug 27, 2023
@Tyriar Tyriar self-assigned this Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant