Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented May 20, 2023

Defined in https://www.ecma-international.org/publications-and-standards/standards/ecma-48/

Fixes #4499

This implementation does not apply the underline color to the overline and it does not "dodge" the text like underline does. This is simpler and it's ambiguous whether that should happen anyway.

dom

image

canvas

image

webgl

image

@Tyriar Tyriar added this to the 5.2.0 milestone May 20, 2023
@Tyriar Tyriar requested a review from jerch May 20, 2023 17:06
@Tyriar Tyriar self-assigned this May 20, 2023
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet another attribute to look for in the serializer 😱 🤣

LGTM 👍

This implementation does not apply the underline color to the overline and it does not "dodge" the text like underline does. This is simpler and it's ambiguous whether that should happen anyway.

About the color:
Imho using FG color is the only useful option atm, underline color is explicitly defined for underline, but we have nothing like that for overline (plz lets not open Pandora's box here and add another color setting for a rarely used attribute).

About overline cutting through glyphs:
Actually this might help to get an easier distinction from underlines above. Also the use cases in the WT thread suggest this as a visual help for things like a status line - here a "hard border/line" cutting through glyphs might help to get the wanted visual separation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support SGR 53 "overline"

2 participants