Skip to content

Conversation

@meganrogge
Copy link
Member

@meganrogge meganrogge commented Feb 3, 2023

Not sure where the code that makes Shift Tab enter this mode is, but it doesn't work when not using screen reader mode. Perhaps that's fine though and will leave it up to the embedders

@meganrogge meganrogge requested a review from Tyriar February 3, 2023 18:35
@meganrogge meganrogge self-assigned this Feb 3, 2023
@meganrogge meganrogge added this to the 5.2.0 milestone Feb 3, 2023
// Listen for mouse events and translate
// them into terminal mouse protocols.
this.bindMouse();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to put this here so that dimensions from the render service wouldn't be 0. lmk if there's a better place

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right function, I'd put it just below the AccessibilityManagers init to be a little more organized. If you needed to move it here then something must not have been migrated to the new file correctly as it was working before when bundled into AccessibilityManager.

Unless that only worked when toggling screenReaderMode on after Terminal was opened? In that case there's probably some other event we're not listening to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's where I put it originally and it didn't work, so seems like we're missing something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs to be after this to work

    this._charSizeService.measure();

@meganrogge meganrogge enabled auto-merge (squash) February 3, 2023 18:49
@meganrogge meganrogge merged commit 6daadc4 into xtermjs:master Feb 3, 2023
meganrogge added a commit that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants