Skip to content

fix accessibility dom structure #4383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 4 commits into from
Jan 24, 2023
Merged

fix accessibility dom structure #4383

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ce048c
append child, not as adjacent
meganrogge Jan 24, 2023
e4fdf56
move lower
meganrogge Jan 24, 2023
e011b8c
Put all a11y elements under a single element
Tyriar Jan 24, 2023
48d7406
Remove readonly
Tyriar Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser/AccessibilityManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export class AccessibilityManager extends Disposable {
) {
super();
this._accessibilityTreeRoot = document.createElement('div');
this._terminal.element?.appendChild(this._accessibilityTreeRoot);
this._accessibilityTreeRoot.classList.add('xterm-accessibility');
this._accessibilityTreeRoot.tabIndex = 0;

Expand Down Expand Up @@ -89,6 +88,7 @@ export class AccessibilityManager extends Disposable {
if (!this._terminal.element) {
throw new Error('Cannot enable accessibility before Terminal.open');
}
this._terminal.element?.appendChild(this._accessibilityTreeRoot);

this._accessiblityBuffer = document.createElement('textarea');
this._accessiblityBuffer.ariaLabel = Strings.accessibilityBuffer;
Expand Down