Skip to content

Fixes disappearance of characters in webgl renderer #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 2 commits into from
Nov 23, 2022
Merged

Fixes disappearance of characters in webgl renderer #4271

Tyriar merged 2 commits into from
Nov 23, 2022

Conversation

@jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Nov 22, 2022

@jeanp413 jeanp413 mentioned this pull request Nov 22, 2022
Closed
Tyriar
Tyriar reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanp413 could you explain what the problem was? Would help me out plus be good to have here for posterity.

@Tyriar Tyriar added this to the 5.1.0 milestone Nov 22, 2022
@Tyriar Tyriar self-assigned this Nov 22, 2022
@Tyriar Tyriar mentioned this pull request Nov 22, 2022
Closed
@jeanp413
Copy link
Contributor Author

jeanp413 commented Nov 22, 2022 •
edited
Loading

Because ITextureAtlas is shared across terminals, if a GlyphRenderer for terminal A sets hasCanvasChanged to false then other terminals B, C, etc won't call _bindAtlasPageTexture and update the texture object in its respective webgl context

Tyriar
Tyriar previously requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks. Just one comment that would make it a lot easier to understand imo

@Tyriar Tyriar enabled auto-merge November 23, 2022 16:46
@Tyriar Tyriar merged commit 452241c into xtermjs:master Nov 23, 2022
@jeanp413 jeanp413 deleted the fix-vscode-166158 branch November 23, 2022 18:24
This was referenced Nov 30, 2022
Closed
Closed
@Tyriar Tyriar mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar left review comments

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

Disappearance of characters and whole lines when opening multiple terminals

2 participants

@jeanp413 @Tyriar