Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 15, 2022

New rules:

  • Check parameter names, they are still not required but if they are specified they must be specified in order; they don't need to be complete but only trailing params can be omitted. The main thing this catches is misspelt or stale params that were documented but changed.
  • No accidental:
    /*
    *
    */
  • No accidental
    /*
     *
     * */
  • No accidental
    /*
     * * 
     */

@Tyriar Tyriar added this to the 5.1.0 milestone Oct 15, 2022
@Tyriar Tyriar self-assigned this Oct 15, 2022
@Tyriar Tyriar enabled auto-merge October 15, 2022 15:46
@Tyriar Tyriar merged commit 16ea621 into xtermjs:master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant