protection flag support #4098
Merged
protection flag support #4098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Tyriar
requested changes
Sep 7, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
Haven't tested but looks good other than my clean up comment
Tyriar
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3651.
TODO:
@Tyriar Rewrote the PR, this time without additional work in
InputHandler.print, so this should not impact normal print data flow at all. 💪Sidenote: Due to changing DECRQSS into an InputHandler function with some inline definitions I could save >3kB on the package.
Edit: Also fixed some feature docs, thus the website should be re-deployed at some point (still on v4.14).