Skip to content

return 0 instead of -1 for no result find count #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meganrogge merged 2 commits into from
Jun 27, 2022
Merged

return 0 instead of -1 for no result find count #3874

meganrogge merged 2 commits into from
Jun 27, 2022

Conversation

@meganrogge
Copy link
Member

@meganrogge meganrogge commented Jun 26, 2022

fixes #3832

@meganrogge meganrogge self-assigned this Jun 26, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone Jun 26, 2022
@meganrogge meganrogge requested a review from Tyriar June 26, 2022 22:43
Tyriar
Tyriar requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the tests for this.

@meganrogge meganrogge requested a review from Tyriar June 27, 2022 17:41
@meganrogge meganrogge merged commit e77a0ec into xtermjs:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels

None yet

Projects

None yet

Milestone

4.19.0

Development

Successfully merging this pull request may close these issues.

Search onDidChangeResults event should return count 0, index -1 when there are no results

2 participants

@meganrogge @Tyriar