Skip to content

Only create decoration elements when they are actually rendered #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tyriar merged 1 commit into from
May 9, 2022
Merged

Only create decoration elements when they are actually rendered #3769

Tyriar merged 1 commit into from
May 9, 2022

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented May 9, 2022 •
edited
Loading

Part of microsoft/vscode#145751

Searching "se" after tree.

Before:

image

After:

image

@Tyriar Tyriar added this to the 4.19.0 milestone May 9, 2022
@Tyriar Tyriar requested a review from meganrogge May 9, 2022 17:52
@Tyriar Tyriar self-assigned this May 9, 2022
@Tyriar Tyriar merged commit 0c4ee0d into xtermjs:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

4.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Tyriar @meganrogge