Skip to content

refine name for clearDecorations param #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 3 commits into from
May 2, 2022
Merged

refine name for clearDecorations param #3757

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71705a2
better name for clearDecorations param
meganrogge May 2, 2022
a015c0d
remove comment now that there's a better name
meganrogge May 2, 2022
3d2d343
Merge branch 'master' into merogge/cached-term
meganrogge May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions addons/xterm-addon-search/src/SearchAddon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export class SearchAddon implements ITerminalAddon {
this._onResizeDisposable?.dispose();
}

public clearDecorations(internal?: boolean): void {
public clearDecorations(retainCachedSearchTerm?: boolean): void {
this._selectedDecoration?.dispose();
this._searchResults?.clear();
this._resultDecorations?.forEach(decorations => {
Expand All @@ -110,11 +110,7 @@ export class SearchAddon implements ITerminalAddon {
this._resultDecorations?.clear();
this._searchResults = undefined;
this._resultDecorations = undefined;
if (!internal) {
// we want to keep _cachedSearchTerm defined if this is
// an internal call
// so that when the buffer changes,
// we can use that to search for new matches
if (!retainCachedSearchTerm) {
this._cachedSearchTerm = undefined;
}
}
Expand Down