Skip to content

Conversation

@meganrogge
Copy link
Member

No description provided.

@meganrogge meganrogge changed the title Merogge/consolidate align isPowerlineGlyph across renderers Apr 20, 2022
@meganrogge meganrogge requested a review from jerch April 20, 2022 21:13
@meganrogge meganrogge self-assigned this Apr 20, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone Apr 20, 2022
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yepp, coolio 👍

This separation has another advantage - if the wider nerdfont codepoints create issues in the future, they simply can be added there a well.

@meganrogge meganrogge merged commit da33543 into xtermjs:master Apr 20, 2022
@Tyriar
Copy link
Member

Tyriar commented May 2, 2022

The intent was only to treat the "powerline" symbols specially which are the first 37 according to https://www.nerdfonts.com/

@jerch
Copy link
Member

jerch commented May 3, 2022

@Tyriar Oh well, then - ah already fixed. 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants