Skip to content

exclude powerline char range from contrast demands #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 11 commits into from
Apr 19, 2022
Merged

exclude powerline char range from contrast demands #3740

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
200e667
queue refresh when deco is removed
meganrogge Apr 19, 2022
fb58eec
don't get contrast color for powerline char range
meganrogge Apr 19, 2022
95a587e
Merge branch 'master' into merogge/color
meganrogge Apr 19, 2022
7dbda6f
Update src/browser/renderer/BaseRenderLayer.ts
meganrogge Apr 19, 2022
500753f
Update src/browser/renderer/BaseRenderLayer.ts
meganrogge Apr 19, 2022
6764794
tweak comments
meganrogge Apr 19, 2022
71c2498
use getCode
meganrogge Apr 19, 2022
043ff62
combine conditionals
meganrogge Apr 19, 2022
6141256
no need to check content
meganrogge Apr 19, 2022
379aa2b
Update src/browser/renderer/BaseRenderLayer.ts
meganrogge Apr 19, 2022
917a202
fix indentation
meganrogge Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/browser/renderer/BaseRenderLayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,13 @@ export abstract class BaseRenderLayer implements IRenderLayer {
}

private _getContrastColor(cell: CellData): IColor | undefined {
// skip empty cells
if (cell.content !== 4194304) {
if (cell.getAsCharData()[3] >= 57344 && cell.getAsCharData()[3] <= 63743) {
// powerline chars #3739
return undefined;
}
}
if (this._optionsService.rawOptions.minimumContrastRatio === 1) {
return undefined;
}
Expand Down