Skip to content

don't throw if row > terminal.rows #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meganrogge merged 1 commit into from
Mar 23, 2022
Merged

don't throw if row > terminal.rows #3709

meganrogge merged 1 commit into from
Mar 23, 2022

Conversation

@meganrogge
Copy link
Member

@meganrogge meganrogge commented Mar 23, 2022 •
edited
Loading

Checking cols here still to prevent the issue from occurring again where an invalid startCol is provided and the search is abbreviated

@meganrogge meganrogge self-assigned this Mar 23, 2022
@meganrogge meganrogge requested a review from Tyriar March 23, 2022 23:20
@meganrogge meganrogge merged commit 7836097 into xtermjs:master Mar 23, 2022
@Tyriar Tyriar deleted the rows branch March 24, 2022 13:15
@Tyriar Tyriar added this to the 4.19.0 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels

None yet

Projects

None yet

Milestone

4.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@meganrogge @Tyriar