Skip to content

Conversation

@meganrogge
Copy link
Member

@meganrogge meganrogge commented Mar 23, 2022

I believe the search results were incomplete because when a result started on the last col, incrementing col by 1 resulted in an invalid place to begin the next search, so no result would be found and it would return

Fixes #3706

@meganrogge meganrogge requested a review from Tyriar March 23, 2022 17:57
@meganrogge meganrogge self-assigned this Mar 23, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone Mar 23, 2022
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that explains it

@meganrogge meganrogge merged commit 544c100 into xtermjs:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find matches are sometimes incomplete

2 participants