WIP feat: add ship combat phases and track in encounter #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make call at run and not before ready
- move from change.mode to change.type (now string not number) - use change.phase and core applyActiveEffects instead of custom override of applyActiveEffects - define ActiveEffect phases still need phase migration
Big simplification to leverage core FVTT interaction
effect still on actor and not augment
make description boxes for skills more responsive Allow chat area when sidebar collapsed to have more height
need to validate roll formulas
marvin9257
changed the title
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feat
What is the current behavior? (You can also link to an open issue here)
no ship combat phase tracking
What is the new behavior (if this is a feature change)?
track phases
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: