Fixed #1759 #1787
Merged
Fixed #1759 #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsanford
reviewed
Oct 12, 2023
Contributor
alexsanford
left a comment
alexsanford
left a comment
There was a problem hiding this comment.
@0n1shi I just tested this, and it works well!
One small change request, and then we should be able to get this merged.
| found = [] | ||
|
|
||
| enumerate(potential_urls(opts), opts.merge(check_full_response: 200)) do |res| | ||
| enumerate(potential_urls(opts), opts.merge(check_full_response: [200, 206])) do |res| |
Contributor
There was a problem hiding this comment.
Could we use valid_response_codes here, rather than repeating the array?
Contributor
Author
There was a problem hiding this comment.
Thank you for the review !
I thought I should follow the other finders but using valid_response_codes is much better, I will fix it :)
alexsanford
approved these changes
Oct 13, 2023
Contributor
alexsanford
left a comment
alexsanford
left a comment
There was a problem hiding this comment.
Tested, works fine for me. Will merge once the build finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1759