Append input found to error message in TypeGuardError #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor in decorators, align code style
…ed now; explicitly parse integer when accessing array elements
Owner
|
Thanks, good stuff! :) |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/woutervh-/typescript-is/issues/57
Hi @woutervh- I took a stab at adding info about the input data to the error message of TypeGuardError. For example:
'TypeGuardError: validation failed at undefined: expected a number, found: undefined''TypeGuardError: validation failed at $.children.[0].children: expected an array, found: null''TypeGuardError: validation failed at $.children: expected an array, found: "foo"'I'm not sure if you're OK with the error message including the data at the error path, but we've been using a custom catcher in some places which replaces the error message as defined in this PR and found it very helpful!
I was also considering adding an option to gate the printing of the "found" data into the error message but couldn't figure out how/wheter options can be accessed from index.js
Test plan: existing unit tests