node(governor): Add defense in depth checks for computeValue #4618
+148
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnsaigle
commented
Dec 11, 2025
johnsaigle
commented
- Modify computeValue to validate its parameters. The callers are already safe in each instance, but this helps to facilitate unit tests and refactoring
- Add Price validation for mainnet tokens (must be non-nil and non-negative)
- Try to avoid unnecessary copies of tokens and chains in unit tests
johnsaigle
added
node
governor
quality
- Modify computeValue to validate its parameters. The callers are already safe in each instance, but this helps to facilitate unit tests and refactoring - Add Price validation for mainnet tokens (must be non-nil and non-negative)
johnsaigle
force-pushed
the
gov-computevalue-checks
branch
from
6e991d5 to
6812e46
Compare
johnsaigle
requested review from
SEJeff,
bemic,
djb15,
mdulin2 and
pleasew8t
as code owners
bemic
reviewed
Dec 12, 2025
djb15
previously approved these changes
Dec 13, 2025
bemic
previously approved these changes
Dec 15, 2025
- Fix comment for computeValue to avoid confusion with the `transfer` type - Rename function to `usdValue()` (presumably most of what we are doing here is computing things)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.