Skip to content

Stacks Watcher Update (Full changes) #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jannik-stacks wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Stacks Watcher Update (Full changes) #4592

jannik-stacks wants to merge 45 commits into from

Conversation

@jannik-stacks
Copy link

@jannik-stacks jannik-stacks commented Nov 21, 2025 •
edited
Loading

Stacks Watcher Update

Base main

Includes PRs

Additional changes

  • Pin a node image version which is more common in the codebase, to increase likelihood of hitting image cache.

Opening for CI runs and further fixes to be pushed in if CI still has failures.

janniks and others added 29 commits November 4, 2025 14:58
@janniks @rdeioris @jannik-stacks
feat: squashed stacks implementation
8ddfde4 
* chore: wip

* chore: wip

* chore: wip pre-polling

* feat: update to polling style

* feat: add reobserve

* docs: update comment

* chore: remove port remnants

* fix: update event logic and contracts

* chore: remove unwanted changes

* chore: clean up test dir

* docs: update readme

* chore: remove contract files for later merging in via separate pr

* Revert "chore: remove contract files for later merging in via separate pr"

This reverts commit 0e3fdaf.

* fix: add more integration progress

* chore: ai progress

* chore: update readme

* chore: update readme

* chore: remove file

* chore: wip

* chore: update scripts for spy test

* fix: add tx_status check for processing stacks transactions in the watcher

* chore: remove outdated test dir (wormhole-foundation#6)

Co-authored-by: janniks <[email protected]>

* refactor(audit): minor updates (wormhole-foundation#7)

* build: remove guardian dependency from stacks node

* refactor: make default parameters configurable

---------

Co-authored-by: janniks <[email protected]>

* fix: update contracts

* fix: ntt eth deploy updates

* chore: rename tmp notes

* fix: cherry pick watcher updates

* chore: update parameters

* fix(audit): update emitter address

* fix: pull in updates

* fix(audit): switch to state contract tracked owner var

* fix: update state contract changes

* chore: update notes

* fix(audit): add active contract fetching

* fix(audit): add max bigint checks, closes #4

* fix(audit): add missing fetch method

* fix(audit): fix incorrect clarity byte

* fix(audit): check burn block confirmation height for reobserve requests, closes #2

* fix: switch to confirmed height rather than processed height

* fix: remove stacks port remnant

* fix: add stacks defaults directly in node config

* chore: remove addressed comments, l1 finalizers not needed for stacks

* chore: update contracts

* fix: add missing c32 file

* added POC for stacks native api

* fixed c32

* reverted variable renaming

* test: update integration style tests

* refactor: move to Tilt tests with it cases

* refactor: update stacks test setup

* refactor: update stacks k8s

* chore: update test files

* test: update spy handling

* chore: update contracts

* test: fix resolve check

* chore: update logs

* fix: remove submodule

* fix: remove submodule

* fix: update integration tests

* fix: switch to latest node develop branch

* fix: type errors

* chore: remove old notes

* refactor: rename native mode

* chore: udpate to v3 endpoints

* fix: add working hacknet

* fix: update contracts

* fix: cleanup config files

* fix: add working nakamoto tx hacknet

* fix: working wormhole message with node only

* fix: minor updates

* fix: update failure checks

* refactor: streamline VAA monitoring

* test: update integration test

* test: add nonce to contract name

* test: fix faulty tests

* test: use pr build for stacks node

---------

Co-authored-by: janniks <[email protected]>
Co-authored-by: Roberto De Ioris <[email protected]>
Co-authored-by: jannik-stacks <[email protected]>
@janniks @jannik-stacks
chore: remove unwanted file
6be8c4c
@janniks @jannik-stacks
fix: update pr according to repo guidelines
a82ca84
@janniks @jannik-stacks
chore: revert go.mod
3dbc533
@janniks @jannik-stacks
fix: pin dockerfiles
1faf5b5
@jannik-stacks
chore: make linter happy
e1102dd
@jannik-stacks
chore: revert gitignore
db6c14b
@jannik-stacks
fix: add txid to message pub
94b4443
@jannik-stacks
chore: cleanup duplicate go mod
b4522fa
@jannik-stacks
chore: undo package change
db0b7d3
@jannik-stacks
chore: repin dockerfiles
600ef6e
@jannik-stacks
chore: add lock files
b13afb3
@jannik-stacks
chore: add lockfiles in dockerfile
b6a3d70
@jannik-stacks
refactor: make success check more verbose
d36a2ac
@jannik-stacks
refactor: ignore uncommitted events
9fe9cdd
@jannik-stacks
fix: add reobservation flag for stacks message pubs
2ff3400
@jannik-stacks
fix: remove unused l1finalizers
f703475
@jannik-stacks
refactor: fix lint errors
d1ece21
@jannik-stacks
docs: update stacks readmes
eccb70b
@jannik-stacks
chore: rename stacks test packages
b497911
@jannik-stacks @janniks @rdeioris
Stacks Implementation (wormhole-foundation#4565)
df2c587 
* feat: squashed stacks implementation

* chore: wip

* chore: wip

* chore: wip pre-polling

* feat: update to polling style

* feat: add reobserve

* docs: update comment

* chore: remove port remnants

* fix: update event logic and contracts

* chore: remove unwanted changes

* chore: clean up test dir

* docs: update readme

* chore: remove contract files for later merging in via separate pr

* Revert "chore: remove contract files for later merging in via separate pr"

This reverts commit 0e3fdaf.

* fix: add more integration progress

* chore: ai progress

* chore: update readme

* chore: update readme

* chore: remove file

* chore: wip

* chore: update scripts for spy test

* fix: add tx_status check for processing stacks transactions in the watcher

* chore: remove outdated test dir (wormhole-foundation#6)

Co-authored-by: janniks <[email protected]>

* refactor(audit): minor updates (wormhole-foundation#7)

* build: remove guardian dependency from stacks node

* refactor: make default parameters configurable

---------

Co-authored-by: janniks <[email protected]>

* fix: update contracts

* fix: ntt eth deploy updates

* chore: rename tmp notes

* fix: cherry pick watcher updates

* chore: update parameters

* fix(audit): update emitter address

* fix: pull in updates

* fix(audit): switch to state contract tracked owner var

* fix: update state contract changes

* chore: update notes

* fix(audit): add active contract fetching

* fix(audit): add max bigint checks, closes #4

* fix(audit): add missing fetch method

* fix(audit): fix incorrect clarity byte

* fix(audit): check burn block confirmation height for reobserve requests, closes #2

* fix: switch to confirmed height rather than processed height

* fix: remove stacks port remnant

* fix: add stacks defaults directly in node config

* chore: remove addressed comments, l1 finalizers not needed for stacks

* chore: update contracts

* fix: add missing c32 file

* added POC for stacks native api

* fixed c32

* reverted variable renaming

* test: update integration style tests

* refactor: move to Tilt tests with it cases

* refactor: update stacks test setup

* refactor: update stacks k8s

* chore: update test files

* test: update spy handling

* chore: update contracts

* test: fix resolve check

* chore: update logs

* fix: remove submodule

* fix: remove submodule

* fix: update integration tests

* fix: switch to latest node develop branch

* fix: type errors

* chore: remove old notes

* refactor: rename native mode

* chore: udpate to v3 endpoints

* fix: add working hacknet

* fix: update contracts

* fix: cleanup config files

* fix: add working nakamoto tx hacknet

* fix: working wormhole message with node only

* fix: minor updates

* fix: update failure checks

* refactor: streamline VAA monitoring

* test: update integration test

* test: add nonce to contract name

* test: fix faulty tests

* test: use pr build for stacks node

---------

Co-authored-by: janniks <[email protected]>
Co-authored-by: Roberto De Ioris <[email protected]>
Co-authored-by: jannik-stacks <[email protected]>

* chore: remove unwanted file

* fix: update pr according to repo guidelines

* chore: revert go.mod

* fix: pin dockerfiles

* chore: make linter happy

* chore: revert gitignore

* fix: add txid to message pub

* chore: cleanup duplicate go mod

* chore: undo package change

* chore: repin dockerfiles

* chore: add lock files

* chore: add lockfiles in dockerfile

* refactor: make success check more verbose

* refactor: ignore uncommitted events

* fix: add reobservation flag for stacks message pubs

* fix: remove unused l1finalizers

* refactor: fix lint errors

* docs: update stacks readmes

* chore: rename stacks test packages

---------

Co-authored-by: janniks <[email protected]>
Co-authored-by: janniks <[email protected]>
Co-authored-by: Roberto De Ioris <[email protected]>
@aadam-10
Merge branch 'ext-integration/stacks' of https://github.com/wormhole-…
9e3c8c2 
…foundation/wormhole into ext-integration/stacks
@mdulin2
Fixed parsing bugs and hardened the Clarity parser:
44b82a6 
* Parse None correctly.
* Parse Signed integers with the signed bit.
* Add length limits to dynamically sized values.
* Add recursive depth limit
* Use 'readFull()' instead of 'read()' on Buff
* Allow empty buffers
@aadam-10
Merge branch 'main' into ext-integration/stacks
b9a5614
@jannik-stacks
fix: add reobserve call and counter
2ffd3a1
@jannik-stacks
fix: add empty block response for not found blocks
ad0d69a
@jannik-stacks
Merge branch 'stacks/add-reobserve-call' into ext-1
4a0f0e8
@jannik-stacks
chore: fix return values
1afd039
@jannik-stacks
Merge branch 'ext-1' into stacks-1
02eb60d
@johnsaigle
Copy link
Contributor

johnsaigle commented Nov 21, 2025

@jannik-stacks it looks like this will take some additional work so that the Tilt tests can pass. In the meantime, we can review the main logic.

johnsaigle
johnsaigle requested changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some initial feedback. However, it looks like this PR doesn't yet contain the full changes: it's missing @mdulin2 's fixes from the Stacks fork of Wormhole.

node/pkg/watchers/stacks/README.md Outdated

## API Endpoints

The watcher interacts with the Stacks Node RPC API endpoints:
Copy link
Contributor

@johnsaigle johnsaigle Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a link to official Stacks documentation here so that we can cross-reference?

stacks/Dockerfile
FROM rust@sha256:234b03300ecaae65919eb8cb13ca9b36588b8dff5b1c69581e361f9f25654db1 AS builder

ARG STACKS_CORE_REPO=https://github.com/stacks-network/stacks-core.git
ARG STACKS_CORE_BASE_BRANCH=develop
Copy link
Contributor

@johnsaigle johnsaigle Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to work from a specific commit hash, ideally one tied to a release? I think we'll want to use a fixed version rather than tracking the latest changes on develop.

@jannik-stacks
Merge branch 'stacks-implementation' into stacks-1
8792723 
# Conflicts:
#	devnet/stacks-bitcoin.yaml
#	devnet/stacks-signer.yaml
#	node/pkg/watchers/stacks/fetch.go
#	node/pkg/watchers/stacks/watcher.go
#	stacks/broadcaster/Dockerfile
#	stacks/stacker/Dockerfile
#	stacks/test/Dockerfile
@jannik-stacks
ci: switch to npm ci install
5abe04e
@jannik-stacks
chore: remove unused fixtures
a130e5a
@jannik-stacks
fix: update clarity parser
17cb241
@jannik-stacks
docs: update readmes
e2651f6
@jannik-stacks
Merge branch 'harden-clarity-parser' into stacks-1
41aa81f 
# Conflicts:
#	node/pkg/watchers/stacks/clarity.go
@jannik-stacks
fix: add canonicalness check
a694343
@jannik-stacks
chore: remove helper
9c49f73
@jannik-stacks
docs: remove non dictionary words
2738e96
@jannik-stacks
chore: update epoch config to include 3.3
0f064a3
@jannik-stacks
ci: update ci config
f4cabbd 
* ci: run ci on this branch

* ci: update runner

* ci: increase mine interval

* chore: trigger ci

* ci: install tilt

* ci: test k3d

* ci: add local registry

* ci: update timing for stacks devnet

* chore: pin stacks node image

* chore: undo ci changes
@jannik-stacks
chore: update pinned images
487d7e0
@jannik-stacks
refactor: move to clarity-go package
0b3e17a
@jannik-stacks
chore: increase stacking length
8a5fd65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnsaigle johnsaigle johnsaigle requested changes

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@fergarrui fergarrui Awaiting requested review from fergarrui fergarrui is a code owner

@djb15 djb15 Awaiting requested review from djb15 djb15 is a code owner

@mdulin2 mdulin2 Awaiting requested review from mdulin2 mdulin2 is a code owner

@pleasew8t pleasew8t Awaiting requested review from pleasew8t pleasew8t is a code owner

@bemic bemic Awaiting requested review from bemic bemic is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jannik-stacks @johnsaigle @janniks @aadam-10 @mdulin2