feat(evm): include contract verificiation in evm contract deployment #4528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk142789
approved these changes
Oct 14, 2025
aapclark
force-pushed
the
improve-evm-deployment-scripts
branch
from
235cdb3 to
10db9ee
Compare
aapclark
requested review from
djb15,
evan-gray,
gator-boi and
kcsongor
as code owners
update readme and verification instructions add template envs for testnet and mainnet deployments update cspell word list update verification document
aapclark
force-pushed
the
improve-evm-deployment-scripts
branch
from
839b93a to
2164cf1
Compare
scnale
reviewed
Oct 17, 2025
ethereum/env/.env.template.mainnet
Outdated
Comment on lines
34
to
35
| BRIDGE_INIT_GOV_CHAIN_ID=0x1 | ||
| BRIDGE_INIT_GOV_CONTRACT=0x0000000000000000000000000000000000000000000000000000000000000004 |
Collaborator
There was a problem hiding this comment.
Maybe we could reuse the definitions?
Suggested change
| BRIDGE_INIT_GOV_CHAIN_ID=0x1 | |
| BRIDGE_INIT_GOV_CONTRACT=0x0000000000000000000000000000000000000000000000000000000000000004 | |
| BRIDGE_INIT_GOV_CHAIN_ID=$INIT_GOV_CHAIN_ID | |
| BRIDGE_INIT_GOV_CONTRACT=$INIT_GOV_CONTRACT |
And similar things could be done for other parameters like the Wormhole chain id too.
Contributor
Author
There was a problem hiding this comment.
Good idea. I'll make those changes.
djb15
previously approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update readme and verification instructions
add template envs for testnet and mainnet deployments