Fix error suppression macro #1199
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous fix triggered another issue: apparently at least GCC expects the `_Pragma` operator to be placed in its own statement (after a semicolon). The current macro simply dumped the expression and the _Pragma together, triggering an error. Putting a semicolon after `Expr` fixes the issue (actually double-checked after a `git clean -fdx`), although slightly changing the API (the semicolon after the wrapped macros is now optional).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous fix triggered another issue: apparently at least GCC expects the
_Pragmaoperator to be placed in its own statement (after a semicolon). The current macro simply dumped the expression and the _Pragma together, triggering an error. Putting a semicolon afterExprfixes the issue (actually double-checked after agit clean -fdx), although slightly changing the API (the semicolon after the wrapped macros is now optional).I'm really sorry for missing this issue before filing the past PR. I had a local workaround still applied and some working object cached, for some reason.
If the semicolon after the macro is desired to be mandatory (I think it was), my only idea would be to add a
do { /* ... */ } while(0)at the end of the patch or similar. I don't know if there are better solutions, unfortunately my macro game is not that strong.