Better control over BLE advertising parameters for Peripheral, also adds a new Advertiser role #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d an Advertiser class.
… response data to bytes.
…f active channels.
…ge and corresponding unit tests.
…d for a specific set of messages rather than a single one. Message handler in mock devices use a decorator to bind them to a message type, but this did not work for messages that have multiple versions as it matches on the exact class name. Therefore, we must route one or multiple message classes to the same method.
…o be specified at once.
… with the tests.
…ipheral and Advertiser connectors.
… interval rather than two distinct parameters.
…data to be instance of `bytes` or `AdvDataFieldList`.
…name in some WHAD protocol messages ('scan_data' changed to 'adv_data')
… to the advertising interval format.
…er class, fixed old stuff too.
virtualabs
force-pushed
the
feature/issue-261
branch
from
7f9d0d0 to
8554d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the WHAD protocol version 3 that adds more options to advertising-related command to control: