-
-
Notifications
You must be signed in to change notification settings - Fork 119
Upgraded tailwindcss and daisyui #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "socialify": patch | ||
| --- | ||
|
|
||
| Upgraded tailwindcss and daisyui |
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please make sure the border radius of the config container matches, and the width of the inputs should be the same~
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed this, but I'm waiting to fix the above issue before making the commit to avoid too many commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make sure the input background colors match up?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure how to test/address this. It looks like the input background color is white on all the tests but on local testing its a dark gray. I checked on Chrome and Brave, both based on Chromium. Will look deeper into this soon.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been able to dedicate some more time now that my classes are over. I'm running into a new issue where the e2e font tests are failing with the error "Failed to fetch font". It's not just in the tests; I tried reaching
wei/socialify/image?description=1&font=Raleway&language=1&name=1&owner=1&pattern=Diagonal%20Stripes&theme=Darkthrough the dev server and got the error message. When I remove "image" from the slug it also give the same error message in the logs but the page renders fine.I tried this in a Codespace and locally and got the error both times. Unfortunately, this is bottlenecking my update because I can't update the test snapshots.