Skip to content

optimize blockquote styles for dark mode #6481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

chenxsan
Copy link
Member

@chenxsan chenxsan commented Nov 4, 2022

Closes #6480

CleanShot 2022-11-04 at 12 59 55@2x

CleanShot 2022-11-04 at 13 00 09@2x

@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 5:03AM (UTC)

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@@ -64,6 +64,34 @@ body {
color: #82b7f6;
}
}

aside.tip,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a NIT. You could have actually extracted the aside separately and nested &.tip. &.warning that way we could have moved all aside code to one place.

@chenxsan chenxsan merged commit 1be2ca9 into webpack:master Nov 4, 2022
@chenxsan chenxsan deleted the feature/fix-blockquote-styles branch November 4, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreadable <code> nested inside link in a tip
3 participants