Integrated vs Classic pipeline

[Yozer]

Hi!

I see that the project currently uses the classic pipeline and it's hardcoded to not use the integrated way.
Is there a reason for that?
While testing my application I discovered some differences in behavior (triggered by MaterializeHandlerExecutionStep which is only in the integrated mode). I didn't dig yet into what are the differences.

[simonegli8]

No there's no reason, but I don't fully understand what you mean. You mean it uses the configuration of the classic pipeline? Because ASP.NET Core will be started by the ASP.NET Core Hosting Bundle, and in it's config one cannot specify classic or integrated mode. I think the code uses the configuration for the classic pipeline, because the configuration for the integrated mode like the <webServer> section is handled by IIS, not ASP.NET.

[Yozer]

So what I mean is that _useIntegratedPipeline toggle is false:
https://github.com/webformsforcore/WebFormsForCore/blob/ec80e052c8f866beff4d717074df5a17f68d411e/src/WebFormsForCore.Web/HttpRuntime.cs#L1445C18-L1445C63

and depending on this toggle there are two different set of steps:
https://github.com/webformsforcore/WebFormsForCore/blob/ec80e052c8f866beff4d717074df5a17f68d411e/src/WebFormsForCore.Web/HttpApplication.cs#L2005C1-L2012C7

the PipelineSteps are using MaterializeHandlerExecutionStep which does something special to my app

WebFormsForCore/src/WebFormsForCore.Web/HttpApplication.cs

Line 4793 in ec80e05

IExecutionStep materializeStep = new MaterializeHandlerExecutionStep(app);

I didn't investigate what yet, but looks like it's able to resolve proper handler here:

WebFormsForCore/src/WebFormsForCore.Web/HttpApplication.cs

Line 3970 in ec80e05

handler = factory.GetHandler(context, request.RequestType, request.FilePath, pathTranslated);

I still need to do some more digging but I wanted to understand what would happen if I would simple set _useIntegratedPipeline to true (I didn't try it yet). And why it's not by default set to true (integrated mode is better/newer than classic)

[simonegli8]

I guess that the IIS will set _useIntegratedPipeline here in HttpRuntime.cs:

        internal static void PopulateIISVersionInformation() {
            if (IsEngineLoaded) {
                uint dwVersion;
                bool fIsIntegratedMode;
                UnsafeIISMethods.MgdGetIISVersionInformation(out dwVersion, out fIsIntegratedMode);

                if (dwVersion != 0) {
                    // High word is the major version; low word is the minor version (this is MAKELONG format)
                    _iisVersion = new Version((int)(dwVersion >> 16), (int)(dwVersion & 0xffff));
                    _useIntegratedPipeline = fIsIntegratedMode;
                }
            }
        }

We might want to introduce an option for the UseWebForms middleware that sets _useIntegratedPipeline.

[simonegli8]

I did push a commit with a middleware option to set Classic mode, default is now Integrated mode.

[simonegli8]

This is implemented in 1.3.14. Integrated mode is the default and one can switch to classic mode with

app.UseWebForms(options => options.UseClassicMode());

[simonegli8]

There was a bug in 1.3.14 in Integrated mode, so I switched back the default mode to Classic mode, and Integrated mode can be enabled by options.UseIntegratedMode(). I don't know if it is working tough.
When calling HttpRuntime.Process there was an expetion in Integrated mode, and a comment that this method is not supported in Integrated mode, so probably Integrated mode will not run without any problems, since the comment says it's not supported