Skip to content

JWK creation from a shared secret #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2018
Merged

JWK creation from a shared secret #57

merged 8 commits into from
Jan 29, 2018

Conversation

Spomky
Copy link
Member

@Spomky Spomky commented Dec 22, 2017

Q A
Branch? v1.1
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets
License MIT
Tests added Yes
Doc PR web-token/jwt-doc#1

This PR adds a new method to the JWK Factory (web-token/jwt-key-mgmt).
It is now easier to create a JWK from a shared secret:

$jwk = JWKFactory::createFromSecret('My Secret Key');

The bundle can also take advantage of this new method:

jose:
    keys:
        my_share_key:
            secret: # New key type
                secret: 'This is my secret'
                additional_values:
                    use: 'sig'
                    alg: 'RS512'
                is_public: true

@Spomky Spomky added the feature label Dec 22, 2017
@Spomky Spomky added this to the Version 1.1.0 milestone Dec 22, 2017
@Spomky Spomky self-assigned this Dec 22, 2017
@coveralls
Copy link

coveralls commented Dec 22, 2017

Coverage Status

Coverage decreased (-0.07%) to 86.039% when pulling 314438d on KeyFromSecret into a1b60e8 on v1.0.

@coveralls
Copy link

coveralls commented Dec 22, 2017

Coverage Status

Coverage increased (+0.3%) to 86.45% when pulling 36d7e01 on KeyFromSecret into 52a12b6 on v1.1.

@Spomky Spomky changed the base branch from v1.0 to v1.1 January 6, 2018 14:42
Spomky added a commit to web-token/jwt-doc that referenced this pull request Jan 19, 2018
This commit includes the documentation for the web-token/jwt-framework#57
@Spomky Spomky merged commit 69089ca into v1.1 Jan 29, 2018
@Spomky Spomky deleted the KeyFromSecret branch January 29, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants