Skip to content

Bugs/okp key creation #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Bugs/okp key creation #399

merged 1 commit into from
Aug 24, 2022

Conversation

Spomky
Copy link
Member

@Spomky Spomky commented Aug 24, 2022

Q A
Branch? 3.1.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #356
License MIT

@gitguardian
Copy link

gitguardian bot commented Aug 24, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
4242658 Generic Private Key 4379a59 tests/Component/KeyManagement/Keys/ED/private-secp384r1-with-public.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Spomky Spomky changed the base branch from 4.0.x to 3.1.x August 24, 2022 06:05
@Spomky Spomky self-assigned this Aug 24, 2022
@Spomky Spomky added the bug label Aug 24, 2022
@Spomky Spomky added this to the 3.1.1 milestone Aug 24, 2022
@Spomky Spomky merged commit 0ef6de1 into 3.1.x Aug 24, 2022
@Spomky Spomky deleted the bugs/okp-key-creation branch August 24, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EdDSA fail to sign
1 participant