Fix Symfony 5.1 deprecation #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a conditional to use service() if existing with fallback to ref() otherwise to support Symfony 4.4.
|
@Spomky what do you think? Maybe you have a better idea? |
|
Hi @monojp, Many thanks. I am not a big fan of method names in variables, bug this will work anyhow. Regards. |
|
Hi @Spomky, do you mind creating a new patch release for 2.2 to release the latest fixes like this one? |
|
Hi @herndlm, I've just created the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a conditional to use service() if existing with fallback to ref() otherwise to support Symfony 4.4.
I'm not sure if this is the best way to "fix" this tbh, feel free to suggest something else. It doesn't even make problems currently but I wanted to get rid of the deprecations there :)