-
-
Notifications
You must be signed in to change notification settings - Fork 747
chore: restructure examples and add basic React example #12522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR restructures the examples directory to provide better debugging examples for Rspack. It upgrades the basic example from a minimal two-file setup to a more comprehensive TypeScript-based example with modern tooling, and adds a new React example demonstrating integration with React 19, TypeScript, and hot module replacement.
Key changes:
- Restructured workspace configuration to use explicit example directories
- Enhanced the basic example with TypeScript, modern build configuration, and styled HTML template
- Added a new React example with full TypeScript support, React Refresh, and SWC loader configuration
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Changed examples glob pattern from recursive to single-level |
| pnpm-lock.yaml | Added dependency entries for both basic and React examples |
| examples/react/* | New React example with TypeScript, React 19, and comprehensive rspack configuration |
| examples/basic/* | Complete rewrite of basic example with TypeScript, modern config, and styled template |
| examples/README.md | New README explaining the purpose of the examples directory |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🙈 Size remains the same at 48.12MB |
CodSpeed Performance ReportMerging #12522 will not alter performanceComparing Summary
|
Summary
The previous example is too "basic". This PR restructures examples and add basic React example for debugging.
Checklist