Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

The previous example is too "basic". This PR restructures examples and add basic React example for debugging.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 22, 2025 08:36
@netlify
Copy link

netlify bot commented Dec 22, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 831d850
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69490e34374a370008e2c71f

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the examples directory to provide better debugging examples for Rspack. It upgrades the basic example from a minimal two-file setup to a more comprehensive TypeScript-based example with modern tooling, and adds a new React example demonstrating integration with React 19, TypeScript, and hot module replacement.

Key changes:

  • Restructured workspace configuration to use explicit example directories
  • Enhanced the basic example with TypeScript, modern build configuration, and styled HTML template
  • Added a new React example with full TypeScript support, React Refresh, and SWC loader configuration

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Changed examples glob pattern from recursive to single-level
pnpm-lock.yaml Added dependency entries for both basic and React examples
examples/react/* New React example with TypeScript, React 19, and comprehensive rspack configuration
examples/basic/* Complete rewrite of basic example with TypeScript, modern config, and styled template
examples/README.md New README explaining the purpose of the examples directory
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 823.4 KB 0
react-5k 2.7 MB 0
rome 984.3 KB 0
ui-components 2.1 MB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

📦 Binary Size-limit

Comparing 831d850 to chore: bump swc_core from 50.2.3 to 52.0.0 and swc_experimental from 0.3.3 to 0.3.5 (#12518) by CPunisher

🙈 Size remains the same at 48.12MB

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 22, 2025

CodSpeed Performance Report

Merging #12522 will not alter performance

Comparing update_examples_1222 (831d850) with main (62c494a)

Summary

✅ 17 untouched

@chenjiahan chenjiahan requested a review from hardfist December 22, 2025 09:12
@chenjiahan chenjiahan enabled auto-merge (squash) December 22, 2025 09:13
@chenjiahan chenjiahan merged commit 152ab9e into main Dec 22, 2025
75 of 78 checks passed
@chenjiahan chenjiahan deleted the update_examples_1222 branch December 22, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants