fix: provide unique function names #5990
Open
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare cases (cowsay), we have multiple function indices sharing a common function name (`dummy` in my case). Similarly to wasm2wat, provide a unique name to the function (useful for `--compiler-debug-dir` option).
marxin
force-pushed
the
preserve-unique-function-names
branch
from
696642d to
78a5431
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses duplicate function names in WebAssembly modules by ensuring each function receives a unique name, similar to the behavior in wasm2wat. This is particularly useful for the --compiler-debug-dir option when analyzing modules with duplicate function names (e.g., multiple functions named "dummy" in cowsay).
Key Changes:
- Modified name section parsing to detect and handle duplicate function names by appending numeric suffixes (.0, .1, etc.)
- Changed the API from incrementally declaring individual function names to batching all function names and declaring them at once
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/compiler/src/translator/sections.rs | Added duplicate name detection logic using HashSet and generates unique names with numeric suffixes; batches function names in a HashMap before declaration |
| lib/compiler/src/translator/environ.rs | Refactored API to accept a HashMap of all function names at once instead of declaring them individually |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marxin
force-pushed
the
preserve-unique-function-names
branch
from
99729f0 to
78a5431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases (cowsay), we have multiple function indices share a common function name (
dummyin my case). Similarly to wasm2wat, provide a unique name to the function (useful for--compiler-debug-diroption).