-
Notifications
You must be signed in to change notification settings - Fork 1
✨ HTMLViewer에 MainImage 기능 추가 #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
12581d2
HTMLViewer에 mainImage 추가
yeolyi 0e9c9fb
HTMLViewer 스타일 수정
yeolyi f7dbb50
DOMPurify 적용
yeolyi e328d31
리뷰 반영
yeolyi 7b9c6f2
Merge remote-tracking branch 'origin/main' into feat/HTMLViewer
yeolyi e5ac596
잘못된 import order 수정
yeolyi 005751a
Merge remote-tracking branch 'origin/main' into feat/HTMLViewer
yeolyi 0f3d609
리뷰 반영
yeolyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import HTMLViewer, { htmlMock1 } from '@/components/common/HTMLViewer'; | ||
|
||
export default function NewsPostPage() { | ||
return ( | ||
<HTMLViewer | ||
htmlContent={htmlMock1} | ||
mainImage={{ | ||
url: 'https://picsum.photos/801', | ||
width: 320, | ||
height: 240, | ||
}} | ||
/> | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,17 @@ | ||
/** @type {import('next').NextConfig} */ | ||
const nextConfig = { | ||
reactStrictMode: true, | ||
|
||
images: { | ||
remotePatterns: [ | ||
// 테스트용 이미지 관련 | ||
{ | ||
protocol: 'https', | ||
hostname: 'picsum.photos', | ||
pathname: '/**', | ||
}, | ||
], | ||
}, | ||
}; | ||
|
||
module.exports = nextConfig; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아마 내비 만들 때까지만 해도 hooks 폴더가 없었을 거라 여기에 써두었을 것으로 추정되는데 얘도 훅이라면
hooks
에 넣는 건 어떠신가요!이 함수 밑에 있는
findChildWithName
은 페이지들이랑 관련된 것 같으니utils/page.ts
에 넣어놓고...?크게 중요한 부분은 아니니 애매하다면 편한 대로 해도 무방할 듯합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
findChildWithName은 export할 필요가 없어서 useCurrentSegmentNode랑 같이 가도 좋을 것 같고, useCurrentSegmentNode는 hooks로 옮길게요!