Skip to content

feat(core): support permalink: null in frontmatter to disable permalink #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 13 additions & 23 deletions packages/core/src/page/resolvePagePermalink.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,23 @@ export const resolvePagePermalink = ({
pathInferred: string | null
pathLocale: string
}): string | null => {
// use permalink in frontmatter directly
// frontmatter.permalink has the highest priority
if (frontmatter.permalink === null) {
return null
}
if (isString(frontmatter.permalink)) {
return frontmatter.permalink
}

// get permalink pattern
const permalinkPattern = getPermalinkPattern({ app, frontmatter })
if (permalinkPattern === null) {
// frontmatter.permalinkPattern has higher priority than app.options.permalinkPattern
if (frontmatter.permalinkPattern === null) {
return null
}

const permalinkPattern =
frontmatter.permalinkPattern || app.options.permalinkPattern

if (!isString(permalinkPattern)) {
return null
}

Expand All @@ -45,22 +54,3 @@ export const resolvePagePermalink = ({

return ensureLeadingSlash(link)
}

/**
* Get permalink pattern from frontmatter or app options
*/
const getPermalinkPattern = ({
app,
frontmatter,
}: {
app: App
frontmatter: PageFrontmatter
}): string | null => {
if (frontmatter.permalinkPattern === null) {
return null
}
if (isString(frontmatter.permalinkPattern)) {
return frontmatter.permalinkPattern
}
return app.options.permalinkPattern
}
15 changes: 15 additions & 0 deletions packages/core/tests/page/resolvePagePermalink.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,21 @@ describe('core > page > resolvePagePermalink', () => {
expect(resolved).toBe('/frontmatter')
})

it('should return null', () => {
const resolved = resolvePagePermalink({
app: appWithPermalinkPattern,
frontmatter: {
permalink: null,
},
slug: '',
date: '',
pathInferred: '/inferred',
pathLocale: '',
})

expect(resolved).toBe(null)
})

it('should use permalinkPattern in frontmatter', () => {
const resolved = resolvePagePermalink({
app,
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/types/page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export type PageFrontmatter<
head?: HeadConfig[]
lang?: string
layout?: string
permalink?: string
permalink?: string | null
permalinkPattern?: string | null
routeMeta?: Record<string, unknown>
title?: string
Expand Down