[megatron] fix: compatible with older megatron version for NPU CI #4116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to improve compatibility with older versions of Megatron by safely accessing configuration attributes. The approach of using getattr is correct. However, the change is incomplete as one of the related configuration flags, align_grad_reduce, is still hardcoded. I've provided a suggestion to address this to make the compatibility fix more robust.
wuxibin89
approved these changes
Nov 14, 2025
chenjiaoAngel
added a commit
to chenjiaoAngel/verl
that referenced
this pull request
Nov 14, 2025
…lcengine#4116) previously at volcengine#4086 I add a function `register_megatron_training_hooks`, in which we will retrieve several arguments from ddp_config and optimizer_config. Some of the arguments is introduced in newer versions of megatron. This PR is to make compatible with older versions, especially the NPU CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously at #4086 I add a function
register_megatron_training_hooks, in which we will retrieve several arguments from ddp_config and optimizer_config. Some of the arguments is introduced in newer versions of megatron.This PR is to make compatible with older versions, especially the NPU CI.