-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Revise the user documentation for hypernode auto discovery #4654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise the user documentation for hypernode auto discovery #4654
Conversation
Summary of ChangesHello @zhaoqi612, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the user documentation for hypernode auto-discovery by correcting a formatting error in a configuration example. Additionally, it includes a minor update to the project's Go module dependencies to ensure proper dependency management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an indentation issue in a YAML example within the user documentation, improving its readability and correctness. However, the PR also includes unrelated changes to the go.mod file. These changes should be moved to a separate pull request. Furthermore, the dependency change introduces golang.org/x/exp/maps, but the standard library's maps package should be used instead, as the project is on Go 1.24.
go.mod
Outdated
| github.com/vishvananda/netlink v1.3.1-0.20250206174618-62fb240731fa | ||
| go.uber.org/automaxprocs v1.6.0 | ||
| golang.org/x/crypto v0.39.0 | ||
| golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change to go.mod appears unrelated to the primary goal of this pull request, which is to update documentation. It's best practice to keep unrelated changes in separate pull requests to ensure a clean and atomic commit history.1
Furthermore, this change introduces a dependency on golang.org/x/exp/maps. Since the project uses Go 1.24, the maps package from the standard library (available since Go 1.21) should be used instead. This avoids relying on an experimental package and aligns with modern Go practices.2
Style Guide References
Footnotes
-
Each pull request should address a single concern or a small, cohesive set of changes. Mixing dependency updates with documentation fixes makes the change history harder to follow and can complicate rollbacks. ↩
-
When a feature is promoted from an experimental package (like
golang.org/x/exp) to the standard library, the standard library version should be preferred for stability and long-term support. Themapspackage is stable in Go 1.21+. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored
20cd7ef to
4bce300
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4bce300 to
b61fe42
Compare
Signed-off-by: zhaoqi <[email protected]>
b61fe42 to
ee9974c
Compare
|
/lgtm |
…nto hyperNode resources
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Modify the incorrect parts in the user guide for automatic discovery of hypernodes
Which issue(s) this PR fixes:
Fixes #4145
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Verification