Skip to content

Conversation

@Monokaix
Copy link
Member

@Monokaix Monokaix commented Sep 25, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Only load images to kind cluster control plane node to free up disk space to avoid e2e failure

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Copilot AI review requested due to automatic review settings September 25, 2025 08:30
@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 25, 2025
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a disk space cleanup step to the E2E workflow to prevent test failures due to insufficient storage when handling large container images.

  • Adds a Docker system cleanup step before running E2E tests
  • Uses docker system prune to remove unused containers, networks, images, and volumes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


- name: Free up disk space
run: |
docker system prune -a -f --volumes
Copy link

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's trailing whitespace at the end of line 41. Remove the extra spaces after --volumes to keep the file clean.

Suggested change
docker system prune -a -f --volumes
docker system prune -a -f --volumes

Copilot uses AI. Check for mistakes.
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2025
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2025
@Monokaix Monokaix force-pushed the ci branch 2 times, most recently from 37300b8 to e480023 Compare September 26, 2025 01:33
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2025
@Monokaix Monokaix force-pushed the ci branch 5 times, most recently from 2dc7ff5 to 75d62e9 Compare September 26, 2025 06:53
Signed-off-by: Monokaix <[email protected]>
@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2025
@JesseStutler
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2025
@kingeasternsun
Copy link
Contributor

/lgtm

@kingeasternsun
Copy link
Contributor

/approve

1 similar comment
@hwdef
Copy link
Member

hwdef commented Sep 26, 2025

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, kingeasternsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2025
@volcano-sh-bot volcano-sh-bot merged commit 4fd4793 into volcano-sh:master Sep 26, 2025
21 checks passed
@Monokaix Monokaix deleted the ci branch September 26, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants