Fix an issue in vc-scheduler about vgpu device memory allocated

[archlitchi]

related issues:

#4595

[gemini-code-assist]

Summary of Changes

Hello @archlitchi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the vc-scheduler where vGPU device memory and core allocation metrics might have been inaccurately reported due to their update mechanism. By changing the metric updates from incremental additions/subtractions to direct setting of current values, the PR ensures that the reported metrics for vGPU resources are consistently precise and reflect the actual usage at all times.

Highlights

• Metric Correction for vGPU Allocation: The pull request corrects how vGPU device allocated memory and core metrics are updated. Previously, these metrics were incrementally added or subtracted, which could lead to inaccuracies. Now, they are directly set to the current UsedMem and UsedCore values, ensuring the metrics always reflect the precise current allocation.
• Update to metrics.go: In pkg/scheduler/api/devices/nvidia/vgpu/metrics.go, the AddPodMetrics and SubPodMetrics functions have been modified. The Add and Sub operations for VGPUDevicesAllocatedMemory and VGPUDevicesAllocatedCores have been replaced with Set operations to ensure accurate metric reporting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in the vGPU device metrics for allocated memory and cores. The change from using Add() and Sub() to Set() for the Prometheus gauge metrics is appropriate, as the values being reported are the new total allocated resources, not deltas. This ensures the metrics accurately reflect the state of GPU resource allocation. The changes are consistent and improve the correctness of monitoring data.

[archlitchi]

/assign @Monokaix @JesseStutler

[Monokaix]

/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [Monokaix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JesseStutler]

/lgtm