Fix bump version script

[JesseStutler]

What type of PR is this?

/kind bug

What this PR does / why we need it:

1. bump version missed to use git commit -s to sign commit, it will cause the auto PR's CI failed
2. The chart's appVersion does not need a v prefix, therefore needs to modify the script

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[JesseStutler]

/cc @Monokaix

[gemini-code-assist]

Summary of Changes

Hello @JesseStutler, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've made a small but crucial fix to the hack/bump-version.sh script. The purpose of this change is to resolve continuous integration (CI) failures that were occurring in auto-generated pull requests. The core issue was that the git commit command within the script was not signing the commits, which is a requirement for our CI system. By adding the -s parameter, all commits made by the script will now be properly signed, thereby preventing future CI failures related to this issue.

Highlights

• Fixing CI Failures: I've addressed a bug in the "hack/bump-version.sh" script that was causing CI failures for auto-generated pull requests. The issue stemmed from the "git commit" command not signing the commits.
• Script Modification: Specifically, I've added the "-s" parameter to the "git commit" command within the "hack/bump-version.sh" script. This ensures that all commits made by the script are properly signed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR correctly adds the -s flag for signing commits in the version bump script, addressing a CI failure. The change is correct and necessary. I've also included a suggestion to improve how the commit message is constructed in the script for better maintainability and completeness.

[gemini-code-assist]

For better readability and maintainability, you could use a heredoc to construct the multi-line commit message. This approach is generally safer and makes it easier to modify the message in the future.

Additionally, the commit message doesn't mention that go mod tidy is run as part of the script (line 214). It would be good to include this for a more complete commit history.

Here's how you could refactor the commit command:

cat <<EOF | git commit -s -F -
chore: bump version to ${NEW_VERSION}

- Update .release-version to ${NEW_VERSION}
- Update Chart version to ${CHART_VERSION}
- Update image tag version to ${NEW_VERSION}
- Update volcano.sh/apis dependency to ${NEW_VERSION}
- Update development YAML files
- Run go mod tidy
EOF

This change would improve the script's robustness and the clarity of the generated commits.

[JesseStutler]

I think currently it's enough

[JesseStutler]

DRA has a flaky test: [It] supports sharing a claim concurrently, I will take time to check it out

[Monokaix]

/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Monokaix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kingeasternsun]

/lgtm