fix: fix ResourceStrategyFit plugin #4457

LY-today · 2025-07-15T03:03:24Z

Signed-off-by: LY-today <[email protected]>

volcano-sh-bot · 2025-07-15T03:03:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign monokaix
You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gemini-code-assist

Summary of Changes

Hello @LY-today, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the accuracy and robustness of the ResourceStrategyFit scheduling plugin. It addresses inconsistencies in resource allocation scoring by correcting the underlying calculation logic and updating the corresponding design documentation. Furthermore, it improves error handling and refines the test suite to ensure the changes are correctly validated.

Highlights

Corrected Resource Allocation Formulas: The documentation for the MostAllocated and LeastAllocated resource strategies has been updated to accurately reflect the calculation, now incorporating used resources in the formulas (used + requested)/allocable and (allocable - (used + requested))/allocable respectively.
Refined Scoring Calculation: The core scoring logic within the ResourceStrategyFit plugin has been adjusted to ensure k8sFramework.MaxNodeScore and ResourceStrategyFitWeight are explicitly treated as float64 during multiplication, which helps prevent potential precision issues in the final score calculation.
Improved Error Logging: An klog.Errorf statement has been added to the String() method of ResourceStrategyFit to log errors encountered during JSON marshaling, enhancing debuggability.
Test Suite Enhancements: The test suite has been updated to align with the corrected scoring logic, including adjustments to expected score values for specific test cases. Additionally, floating-point comparisons in tests now use an epsilon (math.Abs(got-tt.want) > eps) for more robust validation, and several test function and argument names have been harmonized for consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request addresses a bug in the ResourceStrategyFit plugin. The changes include updates to the documentation, error logging, and test suite. The test suite was improved to properly validate calculations and use appropriate comparisons for floating-point numbers. The plugin's scoring logic was corrected.

gemini-code-assist · 2025-07-15T03:05:36Z

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit.go

 		score /= float64(weightSum)
 	}
-	score *= float64(k8sFramework.MaxNodeScore * int64(weight.ResourceStrategyFitWeight))
+	score *= float64(k8sFramework.MaxNodeScore) * float64(weight.ResourceStrategyFitWeight)


Multiplying by float64(weight.ResourceStrategyFitWeight) twice seems unintentional. It should only be multiplied once to apply the weight of the plugin. Remove the first multiplication to correct the scoring.

Suggested change

score *= float64(k8sFramework.MaxNodeScore) * float64(weight.ResourceStrategyFitWeight)

score *= float64(k8sFramework.MaxNodeScore)

@JesseStutler
This proposal doesn't feel right

Reference binpack.go

You can ignore it

gemini-code-assist · 2025-07-15T03:05:36Z

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit_test.go

-					return
-				}
-				t.Errorf("PlusScore() = %v, want %v", got, tt.want)
+			if got := Score(tt.args.task, tt.args.node, tt.args.weight); math.Abs(got-tt.want) > eps {


Using math.Abs(got-tt.want) > eps for comparing floating-point numbers is good, but eps is not defined within this function's scope. Ensure eps is properly defined or imported to avoid potential issues with the comparison.

@JesseStutler
I don't understand, could you explain it to me?

@LY-today Did you forget to define the eps const?

const ( eps = 1e-8 )

The eps constant is already defined at the top of the file, so this issue can be ignored.

gemini-code-assist · 2025-07-15T03:05:37Z

docs/design/resource-strategy-fit-scheduling.md

 	<tr>
 	    <td>MostAllocated</td>
-	    <td>requested/allocable</td>
+	    <td>(used + requested)/allocable</td>


Consider clarifying that used refers to the resources currently in use by the node, and requested refers to the resources requested by pods that are scheduled to the node but not yet running. This will help readers better understand the formula.

gemini-code-assist · 2025-07-15T03:05:37Z

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit_test.go

 }

-func Test_resourceStrategyFitPlusWeightPlusPlugin_OnSessionOpen(t *testing.T) {
+func Test_resourceStrategyFitWeightPlusPlugin_OnSessionOpen(t *testing.T) {


The test function name Test_resourceStrategyFitWeightPlusPlugin_OnSessionOpen is quite long and contains PlusPlugin which seems like a typo. Renaming it to TestResourceStrategyFitPlugin_OnSessionOpen would improve readability and maintainability.

Suggested change

func Test_resourceStrategyFitWeightPlusPlugin_OnSessionOpen(t *testing.T) {

func TestResourceStrategyFitPlugin_OnSessionOpen(t *testing.T) {

still not resolved.

@Monokaix I have solved it locally. I want to communicate all the commits before pushing. This is just for record.

OK you can remove plus typo now

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit_test.go

gemini-code-assist · 2025-07-15T03:05:37Z

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit_test.go

 			name: "test1",
 			args: args{framework.Arguments{
-				"ResourceStrategyFitPlusWeight": 10,
+				"resourceStrategyFitWeight": 10,


The argument name ResourceStrategyFitPlusWeight is not aligned with the actual argument name resourceStrategyFitWeight being used. Renaming it to resourceStrategyFitWeight would improve clarity.

Suggested change

"resourceStrategyFitWeight": 10,

"resourceStrategyFitWeight": 10,

@JesseStutler
I don't understand, could you explain it to me?

Sorry, you can ignore it if gemini is wrong

The following five issues are similar to this one, can be ignored.

gemini-code-assist · 2025-07-15T03:05:37Z

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit_test.go

 			name: "test3",
 			args: args{framework.Arguments{
-				"ResourceStrategyFitPlusWeight": 10,
+				"resourceStrategyFitWeight": 10,


The argument name ResourceStrategyFitPlusWeight is not aligned with the actual argument name resourceStrategyFitWeight being used. Renaming it to resourceStrategyFitWeight would improve clarity.

Suggested change

"resourceStrategyFitWeight": 10,

"resourceStrategyFitWeight": 10,

gemini-code-assist · 2025-07-15T03:05:37Z

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit_test.go

 			},
 			arguments: framework.Arguments{
-				"ResourceStrategyFitPlusWeight": 10,
+				"resourceStrategyFitWeight": 10,


The argument name ResourceStrategyFitPlusWeight is not aligned with the actual argument name resourceStrategyFitWeight being used. Renaming it to resourceStrategyFitWeight would improve clarity.

Suggested change

"resourceStrategyFitWeight": 10,

"resourceStrategyFitWeight": 10,

gemini-code-assist · 2025-07-15T03:05:37Z

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit_test.go

 			},
 			arguments: framework.Arguments{
-				"ResourceStrategyFitPlusWeight": 10,
+				"resourceStrategyFitWeight": 10,


The argument name ResourceStrategyFitPlusWeight is not aligned with the actual argument name resourceStrategyFitWeight being used. Renaming it to resourceStrategyFitWeight would improve clarity.

Suggested change

"resourceStrategyFitWeight": 10,

"resourceStrategyFitWeight": 10,

gemini-code-assist · 2025-07-15T03:05:37Z

pkg/scheduler/plugins/resource-strategy-fit/resource_strategy_fit_test.go


 	arguments := framework.Arguments{
-		"ResourceStrategyFitPlusWeight": 10,
+		"resourceStrategyFitWeight": 10,


The argument name ResourceStrategyFitPlusWeight is not aligned with the actual argument name resourceStrategyFitWeight being used. Renaming it to resourceStrategyFitWeight would improve clarity.

Suggested change

"resourceStrategyFitWeight": 10,

"resourceStrategyFitWeight": 10,

JesseStutler · 2025-07-22T11:28:40Z

BTW, you should keep the PR's template and not delete it, current PR's description is too brief

Monokaix · 2025-09-19T10:18:56Z

Hi, please solve the comments and we are planning to release 1.13 next week.

kingeasternsun · 2025-09-22T02:31:40Z

Kindly revise and complete the PR description, as the current version is insufficient and cannot be accepted.

Signed-off-by: dapeng <[email protected]>

…fit-enhancement fix: address remaining review comments from PR #4457 for ResourceStrategyFit plugin

Signed-off-by: dapeng <[email protected]> Signed-off-by: Mohit Vinchoo <[email protected]>

Signed-off-by: dapeng <[email protected]>

commit 46ac139 Author: JackyTYang <[email protected]> Date: Sat Oct 18 17:26:26 2025 +0800 fix bugs Signed-off-by: JackyTYang <[email protected]> commit 8aa7de3 Author: JackyTYang <[email protected]> Date: Sat Oct 18 15:41:49 2025 +0800 fix: gofmt/goimports formatting Signed-off-by: JackyTYang <[email protected]> commit 4866245 Author: JackyTYang <[email protected]> Date: Sat Oct 18 15:38:22 2025 +0800 add license Signed-off-by: JackyTYang <[email protected]> commit a953c22 Author: JackyTYang <[email protected]> Date: Sat Oct 18 15:31:47 2025 +0800 pass gomake lint Signed-off-by: JackyTYang <[email protected]> commit 11657ce Author: Wongi, Baek <[email protected]> Date: Tue Oct 14 02:24:12 2025 +0900 fix: ci err caused bt ray e2e default image Signed-off-by: Wongi, Baek <[email protected]> commit ff7cd83 Author: JackyTYang <[email protected]> Date: Sat Oct 18 01:35:05 2025 +0800 change scoreBatchNodeFn and readd NodeOrderFn and fix some bugs Signed-off-by: JackyTYang <[email protected]> commit e1b4618 Author: JackyTYang <[email protected]> Date: Sun Oct 12 15:40:40 2025 +0800 npu implement addQueueResource Fn Signed-off-by: JackyTYang <[email protected]> commit 4f7f0b1 Author: zhaoqi <[email protected]> Date: Fri Sep 26 14:30:20 2025 +0800 revise the user documentation for hypernode auto discovery Signed-off-by: zhaoqi <[email protected]> commit 6611501 Author: JesseStutler <[email protected]> Date: Sun Sep 28 16:36:58 2025 +0800 Fix nodegroup non-strict mode Signed-off-by: JesseStutler <[email protected]> commit 9d45be8 Author: wuyue <[email protected]> Date: Fri Sep 26 18:18:03 2025 +0800 add strict to fit unset affinity queue Signed-off-by: wuyue <[email protected]> commit 3981a74 Author: JesseStutler <[email protected]> Date: Wed Aug 13 16:16:34 2025 +0800 Fix bump version script Signed-off-by: JesseStutler <[email protected]> commit b8f57ff Author: wangdongyang1 <[email protected]> Date: Thu Sep 25 16:17:16 2025 +0800 pod level resource fit Signed-off-by: wangdongyang1 <[email protected]> commit aad94e9 Author: limengxuan <[email protected]> Date: Mon Sep 22 17:53:10 2025 +0800 Fix panic on volcano-vgpu when allocating multiple containers in a pod Signed-off-by: limengxuan <[email protected]> commit a53724c Author: zhangzhifei16 <[email protected]> Date: Tue Sep 23 10:52:35 2025 +0800 chore: Optimize notice logs. Signed-off-by: zhangzhifei16 <[email protected]> commit 677e629 Author: zhangzhifei16 <[email protected]> Date: Mon Sep 1 13:10:36 2025 +0800 feat: Support configuring network-topology via pod annotations Signed-off-by: zhangzhifei16 <[email protected]> chore: Optimize the suggestions proposed by gemini-code-assist Signed-off-by: zhangzhifei16 <[email protected]> chore: Update Volcano API version Signed-off-by: zhangzhifei16 <[email protected]> commit aa7bc35 Author: Hajnal Máté <[email protected]> Date: Fri Sep 5 15:46:48 2025 +0200 fix: race-conditions in knownScalarResources Since the known scalar resources map is read and updated from more then one function, race-conditions could happen. Signed-off-by: Hajnal Máté <[email protected]> commit 8fbf5fe Author: Hajnal Máté <[email protected]> Date: Fri Sep 5 14:41:13 2025 +0200 fix: report all scalar metrics for each queue Fixes: volcano-sh#4529 Previously, if a scalar resource was no longer allocated in a queue (e.g., after a job finished), the metric would retain its old value and not be zeroed out. This led to stale and misleading metrics. This change ensures that every known scalar resource for a queue is always reported, and any missing or unallocated resource is explicitly set to zero. Metrics are properly cleaned up when a queue is deleted, preventing stale data and improving monitoring accuracy. One consequence of this is that if a scalar resource disappears from the cluster, then it's metric will be zeroed and not deleted. Signed-off-by: Hajnal Máté <[email protected]> commit 66f09c1 Author: Monokaix <[email protected]> Date: Fri Sep 26 15:52:08 2025 +0800 Free up disk space Signed-off-by: Monokaix <[email protected]> commit e25cd86 Author: HunterChen <[email protected]> Date: Mon Sep 22 09:22:51 2025 +0800 enhance README formatting with note callouts Signed-off-by: HunterChen <[email protected]> commit 7b4305f Author: zhaoqi <[email protected]> Date: Sat Sep 20 18:21:38 2025 +0800 support identifying network topology from node labels and converted into hyperNode resources Signed-off-by: zhaoqi <[email protected]> commit 9c30b7c Author: wuxiaoabo <[email protected]> Date: Thu Jul 10 21:51:56 2025 +0800 Add sra policy for ResourceStrategyFit Plugin Signed-off-by: wuxiaobao <[email protected]> commit c311d30 Author: Wongi, Baek <[email protected]> Date: Sun Aug 24 19:43:07 2025 +0900 feat: add ray plugin for job Signed-off-by: Wongi, Baek <[email protected]> commit a941841 Author: Monokaix <[email protected]> Date: Tue Sep 23 10:22:13 2025 +0800 Update generate yaml Signed-off-by: Monokaix <[email protected]> commit 3628a70 Author: GoingCharlie <[email protected]> Date: Fri Sep 19 21:38:35 2025 +0800 fix: address review comments and fix bugs Signed-off-by: GoingCharlie <[email protected]> commit 647afad Author: GoingCharlie <[email protected]> Date: Fri Aug 22 18:28:59 2025 +0800 feat: add cron volcano job Signed-off-by: GoingCharlie <[email protected]> commit c8dc3c1 Author: JesseStutler <[email protected]> Date: Tue Jul 15 20:52:43 2025 +0800 Add hierarchical queue support for node group plugin Signed-off-by: JesseStutler <[email protected]> commit 632f2f1 Author: JesseStutler <[email protected]> Date: Mon Jul 14 14:40:45 2025 +0800 Add queue wrapper Co-authored-by: googs1025 <[email protected]> Signed-off-by: JesseStutler <[email protected]> commit 4f15789 Author: Monokaix <[email protected]> Date: Mon Sep 22 14:23:18 2025 +0800 Expose more helm config for agent Signed-off-by: Monokaix <[email protected]> commit e4228d1 Author: Kevin Wang <[email protected]> Date: Thu Sep 18 11:47:24 2025 +0800 update MAINTAINERS.md content, pointing to the new location Signed-off-by: Kevin Wang <[email protected]> commit 30b8087 Author: shentiecheng <[email protected]> Date: Thu Aug 14 15:43:25 2025 +0800 feat: add detail msg for pg event Signed-off-by: shentiecheng <[email protected]> commit 308db4f Author: limengxuan <[email protected]> Date: Mon Sep 15 11:49:54 2025 +0800 update Signed-off-by: limengxuan <[email protected]> commit 9a96802 Author: wangdongyang1 <[email protected]> Date: Wed Sep 17 18:52:43 2025 +0800 fix comment Signed-off-by: wangdongyang1 <[email protected]> commit 37ed4ee Author: wangdongyang1 <[email protected]> Date: Thu Sep 11 10:43:13 2025 +0800 fix mpi controller panic Signed-off-by: wangdongyang1 <[email protected]> commit da15f6f Author: g00673948 <[email protected]> Date: Wed Sep 10 10:53:28 2025 +0800 Sync kube-scheduler:Improve CSILimits plugin accuracy by using VolumeAttachments Signed-off-by: g00673948 <[email protected]> commit 8507365 Author: wangdongyang1 <[email protected]> Date: Thu Jun 5 09:53:54 2025 +0800 hyper node binpack Signed-off-by: wangdongyang1 <[email protected]> commit 2e77111 Author: Monokaix <[email protected]> Date: Tue Sep 2 15:10:10 2025 +0800 use node.futureidle instead when pod has nominatedNodeName Signed-off-by: Monokaix <[email protected]> commit a09e8fe Author: dapeng <[email protected]> Date: Mon Sep 15 11:09:55 2025 +0800 docs: clarify wildcard support and format code in resource-strategy-fit Signed-off-by: dapeng <[email protected]> commit 90ee7b0 Author: limengxuan <[email protected]> Date: Fri Aug 8 11:31:42 2025 +0800 update queue Signed-off-by: limengxuan <[email protected]> commit 978b7d4 Author: ditingdapeng <[email protected]> Date: Wed Aug 20 23:55:13 2025 +0800 fix: address code review comments on wildcard pattern validation Signed-off-by: ditingdapeng <[email protected]> commit 257d84b Author: ditingdapeng <[email protected]> Date: Wed Aug 6 17:14:59 2025 +0800 docs: add wildcard syntax support for ResourceStrategyFit plugin Signed-off-by: ditingdapeng <[email protected]> commit 43d7f73 Author: ditingdapeng <[email protected]> Date: Mon Aug 4 15:15:21 2025 +0800 feat: support wildcard syntax in resource-strategy-fit plugin - Add wildcard pattern validation for resource configurations - Support prefix matching with trailing asterisk (e.g., 'cloudml.gpu/*') - Filter out invalid patterns like single '*' or multiple asterisks - Add comprehensive test cases for wildcard functionality Signed-off-by: ditingdapeng <[email protected]> commit e85e88c Author: Hajnal Máté <[email protected]> Date: Mon Aug 25 11:57:11 2025 +0200 Minor development docs changes Fixing development docs links. Adding e2e log directory and ASDF tools file to gitignore. Fix typo in capacity_test.go. Signed-off-by: Hajnal Máté <[email protected]> commit fb52727 Author: dafu <[email protected]> Date: Wed Aug 27 18:23:25 2025 -0700 Revert "fix: Node resource topology awareness, stop scheduling and notReady" Signed-off-by: dafu <[email protected]> commit 9127a41 Author: suyiiyii <[email protected]> Date: Wed Sep 3 11:06:58 2025 +0800 add permissions for managing namespaces in admission rules Signed-off-by: suyiiyii <[email protected]> commit 3796b4e Author: dapeng <[email protected]> Date: Tue Sep 23 10:41:58 2025 +0800 fix: address PR volcano-sh#4457 review comments Signed-off-by: dapeng <[email protected]> commit 3bff197 Author: LY-today <[email protected]> Date: Tue Jul 15 10:53:40 2025 +0800 fix: fix ResourceStrategyFit plugin Signed-off-by: LY-today <[email protected]> commit b16c806 Author: JackyTYang <[email protected]> Date: Sun Oct 12 15:33:23 2025 +0800 finish scoreBatchNodeOrderFn Signed-off-by: JackyTYang <[email protected]> commit dcb8e05 Author: JackyTYang <[email protected]> Date: Mon Sep 29 16:21:00 2025 +0800 complete basic refactor, the scoreNode function remain to be done Signed-off-by: JackyTYang <[email protected]> commit e51a57a Author: JackyTYang <[email protected]> Date: Thu Aug 28 16:56:26 2025 +0800 register 310p VNPU in device share pool Signed-off-by: JackyTYang <[email protected]> commit 3752823 Author: JackyTYang <[email protected]> Date: Thu Aug 28 15:46:30 2025 +0800 migrate ascend volcano plugin under scheduler/plugin Signed-off-by: JackyTYang <[email protected]> commit 147efde Author: neo502721 <[email protected]> Date: Wed Aug 27 10:37:19 2025 +0800 add test case for podsToKill in job controller killPods action Signed-off-by: neo502721 <[email protected]> commit 9743586 Author: neo502721 <[email protected]> Date: Tue Aug 26 09:58:45 2025 +0800 Fix panic in job controller's killPods action Signed-off-by: neo502721 <[email protected]> commit ba79056 Author: wangdongyang1 <[email protected]> Date: Thu Aug 21 15:50:13 2025 +0800 apply reviewer Signed-off-by: wangdongyang1 <[email protected]> commit 682cb1c Author: wangdongyang1 <[email protected]> Date: Mon Aug 11 09:18:08 2025 +0800 add hcclrank job plugin Signed-off-by: wangdongyang1 <[email protected]> commit 823be88 Author: JesseStutler <[email protected]> Date: Mon Aug 11 16:07:45 2025 +0800 fix dra flaky test Signed-off-by: JesseStutler <[email protected]> commit ee5e2b0 Author: shentiecheng <[email protected]> Date: Mon Aug 11 11:19:50 2025 +0800 fix: deepcopy podgroup before update Signed-off-by: shentiecheng <[email protected]> Signed-off-by: JackyTYang <[email protected]>

Signed-off-by: dapeng <[email protected]>

fix: fix ResourceStrategyFit plugin

05c9fca

Signed-off-by: LY-today <[email protected]>

volcano-sh-bot requested review from lowang-bh and shinytang6 July 15, 2025 03:03

volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 15, 2025

gemini-code-assist bot reviewed Jul 15, 2025

View reviewed changes

ditingdapeng added a commit to ditingdapeng/volcano that referenced this pull request Sep 23, 2025

fix: address PR volcano-sh#4457 review comments

fb2b4e6

ditingdapeng mentioned this pull request Sep 23, 2025

fix: address remaining review comments from PR #4457 for ResourceStrategyFit plugin #4635

Merged

ditingdapeng added a commit to ditingdapeng/volcano that referenced this pull request Sep 23, 2025

fix: address PR volcano-sh#4457 review comments

b15898c

Signed-off-by: dapeng <[email protected]>

volcano-sh-bot added a commit that referenced this pull request Sep 23, 2025

Merge pull request #4635 from ditingdapeng/pr-4457-resource-strategy-…

6078175

…fit-enhancement fix: address remaining review comments from PR #4457 for ResourceStrategyFit plugin

volcano-sh-bot merged commit 05c9fca into volcano-sh:master Sep 23, 2025
28 of 29 checks passed

mvinchoo pushed a commit to mvinchoo/volcano that referenced this pull request Sep 24, 2025

fix: address PR volcano-sh#4457 review comments

e25f99f

Signed-off-by: dapeng <[email protected]> Signed-off-by: Mohit Vinchoo <[email protected]>

JackyTYang pushed a commit to JackyTYang/volcano that referenced this pull request Oct 18, 2025

fix: address PR volcano-sh#4457 review comments

3796b4e

Signed-off-by: dapeng <[email protected]>

Wang-Kai pushed a commit to Wang-Kai/volcano that referenced this pull request Nov 4, 2025

fix: address PR volcano-sh#4457 review comments

65179b0

Signed-off-by: dapeng <[email protected]>

	score = float64(k8sFramework.MaxNodeScore) float64(weight.ResourceStrategyFitWeight)
	score *= float64(k8sFramework.MaxNodeScore)

	func Test_resourceStrategyFitWeightPlusPlugin_OnSessionOpen(t *testing.T) {
	func TestResourceStrategyFitPlugin_OnSessionOpen(t *testing.T) {

	"resourceStrategyFitWeight": 10,
	"resourceStrategyFitWeight": 10,

fix: fix ResourceStrategyFit plugin #4457

fix: fix ResourceStrategyFit plugin #4457

Conversation

LY-today commented Jul 15, 2025

Uh oh!

volcano-sh-bot commented Jul 15, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

LY-today Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

JesseStutler commented Jul 22, 2025

Uh oh!

Monokaix commented Sep 19, 2025

Uh oh!

kingeasternsun commented Sep 22, 2025

LY-today Jul 15, 2025 •

edited

Loading