Fix the issue where SelectBestNode returns nil when plugin scores are… #4445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
guoqinwill
force-pushed
the
fix-selectnode
branch
from
c9bccb8 to
dd7208a
Compare
… negative Signed-off-by: g00673948 <[email protected]>
guoqinwill
force-pushed
the
fix-selectnode
branch
from
dd7208a to
2f2edca
Compare
Member
|
/assign @JesseStutler |
Member
|
Please add some detail describe in PR info. |
Member
|
/lgtm |
Member
|
Also need to cherry-pick it back to release-1.12 and release-1.11, using the |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR primarily strengthens the scheduler's node selection logic by initializing the score to negative infinity. This ensures that even when plugin scores are negative, the scheduler can still return the best node based on the scores, instead of returning nil.
Which issue(s) this PR fixes:
Fixes # #4444
Special notes for your reviewer:
Does this PR introduce a user-facing change?