Skip to content

Conversation

@JesseStutler
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Before releasing a version, Volcano usually needs to submit a PR to manually replace the hard-coded version number in the repository, such as: #4337. This is troublesome and easy to miss some files. Currently, a bump-version.sh is added to help automatically submit a PR to GitHub. The sample PR is: #4371.
This script refers to cherry_pick_pull.sh, and the usage example is as follows:

hack/bump-version.sh origin/master v1.12.0

The script accepts two parameters, the first is the target branch, and the second is the version number to be released. Of course, this script assumes that the repo name of volcano-sh/volcano is upstream, and the repo name of your fork repo is origin. If the name you configure is different, the script can be:

UPSTREAM_REMOTE=origin FORK_REMOTE=downstream hack/bump-version.sh origin/master v1.12.0

And if you don't wish to automatically raise a PR, you can add DRY_RUN=1 env to run it.

Other changes:

  1. Added .release-version file, default configuration is latest, when we need to release a new version, bump-version.sh will replace the value in the .release-version file, and then chart.yaml, code_verify.yaml, e2e_spark.yaml and other files will read the version number from the file
  2. Just need to configure the TAG environment variable when we need to run make generate-yaml. And I fix some error configurations: For example, the RELEASE_TAG environment variable prompted in check-generated-yaml.sh does not actually exist in generate-yaml.sh. Makefile will read the TAG definition of Makefile.def and exports it as a global variable
  3. Rename the volcano-monitoring-[version].yaml to volcano-monitoring.yaml, because there is no volcano-related version in this file, we can safely run make update-development-yaml to generate this file. The tutorial to deploy the monitoring in README.md also change.

Which issue(s) this PR fixes:

Related #4357

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 12, 2025
@JesseStutler
Copy link
Member Author

JesseStutler commented Jun 12, 2025

/cc @Monokaix

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2025
@volcano-sh-bot volcano-sh-bot requested a review from Monokaix June 13, 2025 08:13
@JesseStutler
Copy link
Member Author

Now when master needs to pre-release a TAG, make TAG=[pre-release TAG] verify-generated-yaml will also succeed:
image

@Monokaix
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit complicated
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2025
@volcano-sh-bot volcano-sh-bot merged commit 068b7bc into volcano-sh:master Jun 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants