Add context logger utilities for enhanced logging support

[priyansh17]

Signed-off-by: Priyansh Choudhary [email protected]

Please add a summary of your change

• Do not add the logger to any struct that is marshaled.
• Always pass the logger via context.Context using WithLogger and LoggerFromContext.
• Use this pattern for all backends for consistent behavior.

Fix #9176

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.

[Lyndon-Li]

@priyansh17
Thanks for the fix! Please help to add a changelog for this PR.

[codecov]

Codecov Report

❌ Patch coverage is 25.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.66%. Comparing base (d295314) to head (8d4203e).
⚠️ Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...po/kopialib/backend/azure/azure_storage_wrapper.go	0.00%	7 Missing ⚠️
...sitory/udmrepo/kopialib/backend/logging/context.go	0.00%	7 Missing ⚠️
pkg/repository/udmrepo/kopialib/backend/azure.go	0.00%	1 Missing ⚠️
...repository/udmrepo/kopialib/backend/file_system.go	66.66%	1 Missing ⚠️
pkg/repository/udmrepo/kopialib/backend/gcs.go	66.66%	1 Missing ⚠️
pkg/repository/udmrepo/kopialib/backend/s3.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9168      +/-   ##
==========================================
- Coverage   59.68%   59.66%   -0.02%     
==========================================
  Files         381      382       +1     
  Lines       43879    43900      +21     
==========================================
+ Hits        26189    26194       +5     
- Misses      16145    16161      +16     
  Partials     1545     1545              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kaovilai]

This PR introduces duplicate functionality - Velero already uses Kopia's logging.WithLogger/LoggerFromContext in pkg/kopia/kopia_log.go for context-based logging in Kopia integrations. Since all modified backends are under kopialib/ and return Kopia storage implementations, consider reusing Kopia's existing logging utilities rather than creating a parallel implementation in pkg/repository/udmrepo/logging/.

[Lyndon-Li]

@kaovilai
This PR is to fix the problem introduced by #8875, which causes Velero doesn't work with Azure Blob storage since 1.16. So if we want to remove this extra log mechanism, we should revert the changes in #8875, which is to fix #8827.
I think the logs mentioned in the problem belongs to Velero code and there is no Kopia log available around that code (Kopia code doesn't define logger parameter for the related functions/interfaces), and moreover, Kopia log doesn't respect to --json either (notice that Kopia logs are also in Velero log files).

[Lyndon-Li]

FYI, I have opened a dedicated issue #9176, let's discuss in the issue

[anshulahuja98]

Tag: @kaovilai for any review.

[Lyndon-Li]

@priyansh17 Could you help to cherry-pick this PR to 1.16 branch?

[priyansh17]

@priyansh17 Could you help to cherry-pick this PR to 1.16 branch?

Sure, will raise another PR.

[priyansh17]

@Lyndon-Li I don't see changes in this PR #8875 in the release 1.16 https://github.com/vmware-tanzu/velero/blob/release-1.16/pkg/repository/udmrepo/kopialib/backend/gcs.go

[kaovilai]

@priyansh17 Do you mean to raise a PR to release-1.16 branch so that #9168 make it into release-1.16?

[priyansh17]

@kaovilai I meant @Lyndon-Li mentioned to add this PR into 1.16 but this is a fix for #8875, if the issue isn't in the release there's no need for the solution to go in.

[Lyndon-Li]

@kaovilai I meant @Lyndon-Li mentioned to add this PR into 1.16 but this is a fix for #8875, if the issue isn't in the release there's no need for the solution to go in.

Thanks for the confirmation! My mistake, I previous thought the problematic PR is also in 1.16.