-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add provision for labels and annotations in E2E tests. #9043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provision for labels and annotations in E2E tests. #9043
Conversation
…configuration Signed-off-by: Priyansh Choudhary <[email protected]>
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9043 +/- ##
=======================================
Coverage 60.29% 60.29%
=======================================
Files 378 378
Lines 42729 42729
=======================================
Hits 25763 25763
Misses 15417 15417
Partials 1549 1549 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…service account annotations Signed-off-by: Priyansh Choudhary <[email protected]>
kaovilai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Clean implementation that adds useful E2E test configuration options for pod labels and service account annotations.
…9043) * Add support for pod labels and service account annotations in Velero configuration Signed-off-by: Priyansh Choudhary <[email protected]> * Refactor Velero configuration to use string types for pod labels and service account annotations Signed-off-by: Priyansh Choudhary <[email protected]>
Summary
This PR enhances the Velero E2E test framework by adding support for custom pod labels and service account annotations. These can now be passed as CLI flags during test execution and will be propagated to the Velero deployment during installation.
Why is this change being made?
This change enables:
What changed?
Modified Files:
POD_LABELSandSA_ANNOTATIONSvariables to pass to E2E tests--pod-labelsand--sa-annotationsVeleroConfigstruct with new fieldsUsage Example:
Testing
Notes
Fixes: No specific GitHub issue
Please indicate you've done the following:
/kind changelog-not-required