Remove dependency with VolumeSnapshotClass in DataUpload. #9040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
9034_fix
branch
2 times, most recently
from
b39be24 to
b01e071
Compare
blackpiglet
changed the title
blackpiglet
force-pushed
the
9034_fix
branch
2 times, most recently
from
d336b3a to
753b17f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9040 +/- ##
=======================================
Coverage ? 60.29%
=======================================
Files ? 378
Lines ? 42729
Branches ? 0
=======================================
Hits ? 25763
Misses ? 15417
Partials ? 1549 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shubham-pampattiwar
previously approved these changes
Jun 25, 2025
kaovilai
previously approved these changes
Jun 25, 2025
blackpiglet
dismissed stale reviews from kaovilai and shubham-pampattiwar
via
a2f9b42
Don't add VSClass in the additionalItems when it's empty. Signed-off-by: Xun Jiang <[email protected]> Signed-off-by: xun.jiang <[email protected]>
shubham-pampattiwar
approved these changes
Jun 25, 2025
kaovilai
approved these changes
Jun 25, 2025
sseago
approved these changes
Jun 25, 2025
3 tasks
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
…zu#9040) Don't add VSClass in the additionalItems when it's empty. Signed-off-by: Xun Jiang <[email protected]> Signed-off-by: xun.jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't add VSClass in the additionalItems when it's empty.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #9034
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.