Skip to content

Conversation

@blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jun 10, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #8593

Please indicate you've done the following:

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.31%. Comparing base (b0b5cc4) to head (50ec895).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9013      +/-   ##
==========================================
+ Coverage   60.29%   60.31%   +0.01%     
==========================================
  Files         378      378              
  Lines       42729    42729              
==========================================
+ Hits        25763    25771       +8     
+ Misses      15417    15404      -13     
- Partials     1549     1554       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blackpiglet blackpiglet marked this pull request as ready for review June 10, 2025 10:15
@github-actions github-actions bot requested review from Lyndon-Li and sseago June 10, 2025 10:16
sseago
sseago previously approved these changes Jun 10, 2025
@blackpiglet blackpiglet changed the title Modify the maintenance job clean logic. Add UT for maintenance's DeleteOldJobs function Jun 23, 2025
@blackpiglet
Copy link
Contributor Author

After discussion with @Lyndon-Li, we think the original issue was already fixed in v1.16.0's maintenance job refactor PR.
As a result, I will not modify the maintenance job deletion logic anymore.

@blackpiglet blackpiglet added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes and removed has-changelog labels Jun 23, 2025
@blackpiglet blackpiglet force-pushed the 8593_fix branch 3 times, most recently from 8a77a4d to 0969f62 Compare June 25, 2025 13:16
Unify the k8s.io/api/batch/v1 import alias to bactchv1api.

Signed-off-by: Xun Jiang <[email protected]>
@kaovilai kaovilai merged commit 5ebb055 into vmware-tanzu:main Jun 27, 2025
46 checks passed
@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
Unify the k8s.io/api/batch/v1 import alias to bactchv1api.

Signed-off-by: Xun Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OOMKilled maintenance job pods are getting piled up even if --keep-latest-maintenance-jobs=0

4 participants