-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add UT for maintenance's DeleteOldJobs function #9013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9013 +/- ##
==========================================
+ Coverage 60.29% 60.31% +0.01%
==========================================
Files 378 378
Lines 42729 42729
==========================================
+ Hits 25763 25771 +8
+ Misses 15417 15404 -13
- Partials 1549 1554 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
After discussion with @Lyndon-Li, we think the original issue was already fixed in v1.16.0's maintenance job refactor PR. |
8a77a4d to
0969f62
Compare
Unify the k8s.io/api/batch/v1 import alias to bactchv1api. Signed-off-by: Xun Jiang <[email protected]>
Unify the k8s.io/api/batch/v1 import alias to bactchv1api. Signed-off-by: Xun Jiang <[email protected]>
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8593
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.