Skip to content

Conversation

@vishal-chdhry
Copy link
Contributor

@vishal-chdhry vishal-chdhry commented May 27, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Minio recently removed config subccommand from mc command: minio/mc#5206. This PR updates the commands in minio-setup example to use alias instead of config

Does your change fix a particular issue?

No

Please indicate you've done the following:

Signed-off-by: Vishal Choudhary <[email protected]>
Copy link
Collaborator

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.57%. Comparing base (bfd9bc5) to head (a85f2c6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8982   +/-   ##
=======================================
  Coverage   59.57%   59.57%           
=======================================
  Files         370      370           
  Lines       40278    40278           
=======================================
  Hits        23995    23995           
  Misses      14780    14780           
  Partials     1503     1503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaovilai kaovilai merged commit f3685f3 into vmware-tanzu:main May 28, 2025
46 checks passed
@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
* fix: update mc command in minio-deployment example

Signed-off-by: Vishal Choudhary <[email protected]>

* fix: run make new-changelog

Signed-off-by: Vishal Choudhary <[email protected]>

---------

Signed-off-by: Vishal Choudhary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants