Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 1, 2025

Thank you for contributing to Velero!

Please add a summary of your change

bump golangci-lint to v2

Does your change fix a particular issue?

Fixes #8810

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Apr 1, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 2 times, most recently from 91b956f to 93a18d0 Compare April 1, 2025 06:01
@mmorel-35 mmorel-35 marked this pull request as ready for review April 1, 2025 06:06
@github-actions github-actions bot requested review from reasonerjt and ywk253100 April 1, 2025 06:06
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (0dbff6d) to head (d45e5bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8839   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files         370      370           
  Lines       40246    40246           
=======================================
  Hits        23973    23973           
  Misses      14773    14773           
  Partials     1500     1500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kaovilai
kaovilai previously approved these changes Apr 1, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 15 times, most recently from c1db25a to 5a5ebe6 Compare April 13, 2025 17:03
Signed-off-by: Matthieu MOREL <[email protected]>
uses: golangci/golangci-lint-action@v7
with:
version: v1.64.5
version: v2.1.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not .2?

Copy link
Contributor Author

@mmorel-35 mmorel-35 Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the PR was opened two weeks ago and 2.1.2 was released two days ago.

Copy link
Collaborator

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me locally.

@kaovilai kaovilai merged commit 5705bcc into vmware-tanzu:main Apr 17, 2025
42 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint@v2 branch April 17, 2025 06:43
@MaloLelandais MaloLelandais mentioned this pull request Jul 28, 2025
3 tasks
MaloLelandais pushed a commit to MaloLelandais/velero that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants