-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: bump golangci-lint to v2 #8839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/kind changelog-not-required |
91b956f to
93a18d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8839 +/- ##
=======================================
Coverage 59.56% 59.56%
=======================================
Files 370 370
Lines 40246 40246
=======================================
Hits 23973 23973
Misses 14773 14773
Partials 1500 1500 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c1db25a to
5a5ebe6
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
5a5ebe6 to
d45e5bb
Compare
| uses: golangci/golangci-lint-action@v7 | ||
| with: | ||
| version: v1.64.5 | ||
| version: v2.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not .2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the PR was opened two weeks ago and 2.1.2 was released two days ago.
kaovilai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked for me locally.
Signed-off-by: Matthieu MOREL <[email protected]>
Thank you for contributing to Velero!
Please add a summary of your change
bump golangci-lint to v2
Does your change fix a particular issue?
Fixes #8810
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.