Make logs format more consistent by using server logger for client-go, controller-runtime, requiring upgrade of k8s.io/ to v0.31.3

[kaovilai]

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Upgrade k8s.io/ go.mod to v0.31.3 (minor version used by https://github.com/kubernetes-sigs/controller-tools/blob/v0.16.5/go.mod#L18) and set logger for client-go to use the same logger as the rest of the codebase for consistent logging.
Upgraded controller-gen to version that support the new deps.

cat go.mod | grep '\tk8s.io' | cut -f 2 | cut -d ' ' -f 1 | xargs -I {} -L 1 sh -c 'go get {}@v0.31.3'

Also bumped to support upgraded k8s.io/ deps.

• controller-gen to v0.16.5
• sigs.k8s.io/controller-runtime v0.19.3
• structs/funcs for eventhandlers are updated

Does your change fix a particular issue?

Fixes #3550 #8442

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

[kaovilai]

fyi I need to fix go sum here before merging :D

[kaovilai]

time="2024-11-25T20:27:46Z" level=fatal msg="controller with name backup already exists. Controller names must be unique to avoid multiple controllers reporting to the same metricunable to create controllercontrollerbackup-operations" logSource="pkg/cmd/server/server.go:661"

[kaovilai]

FYI zap is being removed in this PR.

It was meant to be removed here https://github.com/vmware-tanzu/velero/pull/2561/files#r432107463 and was kept here #8046 (comment)

This means all logs are going to be affected by the default logger flags, that means if user want all logs in json, they will get all logs in json.

[codecov]

Codecov Report

Attention: Patch coverage is 24.39024% with 31 lines in your changes missing coverage. Please review.

Project coverage is 59.49%. Comparing base (9235fe1) to head (7a3bca0).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/util/kube/event_handler.go	0.00%	11 Missing ⚠️
internal/hook/wait_exec_hook_handler.go	64.28%	5 Missing ⚠️
pkg/cmd/cli/datamover/backup.go	0.00%	2 Missing ⚠️
pkg/cmd/cli/datamover/restore.go	0.00%	2 Missing ⚠️
pkg/cmd/cli/nodeagent/server.go	0.00%	2 Missing ⚠️
pkg/cmd/server/server.go	0.00%	1 Missing ⚠️
pkg/controller/backup_controller.go	0.00%	1 Missing ⚠️
pkg/controller/backup_finalizer_controller.go	0.00%	1 Missing ⚠️
pkg/controller/backup_operations_controller.go	0.00%	1 Missing ⚠️
...g/controller/backup_storage_location_controller.go	0.00%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8450      +/-   ##
==========================================
- Coverage   59.51%   59.49%   -0.02%     
==========================================
  Files         371      371              
  Lines       40179    40196      +17     
==========================================
+ Hits        23911    23914       +3     
- Misses      14775    14789      +14     
  Partials     1493     1493              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mateusoliveira43]

would be better to break this PR in 2? one for dependencies update and one for logger change?

[kaovilai]

I can save logger change for later but logger change depends on dep bump

[sseago]

@kaovilai @mateusoliveira43 If the logger change requires the dep bump, then it makes more sense to keep them together. Otherwise, we wouldn't necessarily need the dep bump (assuming we're not also fixing a CVE at the same time).

[kaovilai]

reopening to clear 1.32.1 tests which are hitting #8648

[reasonerjt]

@kaovilai please resolve the conflict

[kaovilai]

Resolved!

[reasonerjt]

lgtm