Skip to content

Conversation

@ywk253100
Copy link
Contributor

Add secret restore item action to handle service account token secret:

  1. Skip the restoration for the auto-created service account token secret
  2. Remove several fields for non-auto-created service account token secret to make sure the secret can be restored

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

Codecov Report

Merging #5869 (ee574b7) into release-1.10 (1e015ec) will increase coverage by 0.10%.
The diff coverage is 82.35%.

@@               Coverage Diff                @@
##           release-1.10    #5869      +/-   ##
================================================
+ Coverage         40.85%   40.95%   +0.10%     
================================================
  Files               239      240       +1     
  Lines             20664    20715      +51     
================================================
+ Hits               8442     8484      +42     
- Misses            11605    11611       +6     
- Partials            617      620       +3     
Impacted Files Coverage Δ
pkg/cmd/server/server.go 6.57% <ø> (ø)
pkg/restore/secret_action.go 82.35% <82.35%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Add secret restore item action to handle service account token secret:
1. Skip the restoration for the auto-created service account token secret
2. Remove several fields for non-auto-created service account token secret to make sure the secret can be restored

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@ywk253100 ywk253100 changed the title Add secret restore item action to handle service account token secret [cherry-pick]Add secret restore item action to handle service account token secret Feb 17, 2023
@ywk253100 ywk253100 requested a review from reasonerjt February 17, 2023 09:06
@blackpiglet blackpiglet merged commit 42fb499 into vmware-tanzu:release-1.10 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants