Skip to content

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Mar 28, 2025

Description

Noticed in #7738 and it buggs me a lot

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va requested a review from AriPerkkio March 28, 2025 13:10
@netlify
Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 5a676f6
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67e69fb4589d1300082af0d8
😎 Deploy Preview https://deploy-preview-7752--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va changed the title fix(reporter): report suites in correct order fix(reporter): report tests in correct order Mar 28, 2025
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment on lines 238 to 242
if (test.mode !== 'run' && test.mode !== 'queued') {
updateTask('test-prepare', test, runner)
updateTask('test-finished', test, runner)
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we discussed this as early as in #7069 (comment). Happy to see it landing now! This will make resolving test state's on main thread side much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants