-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(reporter): report tests in correct order #7752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reporter): report tests in correct order #7752
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AriPerkkio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| if (test.mode !== 'run' && test.mode !== 'queued') { | ||
| updateTask('test-prepare', test, runner) | ||
| updateTask('test-finished', test, runner) | ||
| return | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we discussed this as early as in #7069 (comment). Happy to see it landing now! This will make resolving test state's on main thread side much easier.
Description
Noticed in #7738 and it buggs me a lot
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.